This is an automated email from the ASF dual-hosted git repository.
pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 801751ecb23 [Playground] Removed banner from Playground header,
deleted unused assets
new 97a90f0f514 Merge pull request #22410 from
akvelon/pg_22364_remove_banner
801751ecb23 is described below
commit 801751ecb23381ba58ccf8876e130c52d1a1ed9a
Author: Aleksandr Zhuravlev <[email protected]>
AuthorDate: Thu Jul 21 00:29:35 2022 +0400
[Playground] Removed banner from Playground header, deleted unused assets
---
playground/frontend/assets/summit_banner.svg | 40 ----------------------
.../banner_button.dart} | 8 ++---
.../banner_description.dart | 16 ++++-----
playground/frontend/lib/constants/assets.dart | 1 -
.../lib/pages/playground/playground_page.dart | 3 +-
5 files changed, 12 insertions(+), 56 deletions(-)
diff --git a/playground/frontend/assets/summit_banner.svg
b/playground/frontend/assets/summit_banner.svg
deleted file mode 100644
index d3de0cc53c3..00000000000
--- a/playground/frontend/assets/summit_banner.svg
+++ /dev/null
@@ -1,40 +0,0 @@
-<!--
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
--->
-
-<svg width="88" height="42" viewBox="0 0 88 42" fill="none"
xmlns="http://www.w3.org/2000/svg";>
-<g clip-path="url(#clip0_22_6)">
-<path d="M41.0315 27.35H53.017L47.0296 14.7885L41.0315 27.35ZM54.7709
29.9787H39.2904C39.1114 29.9781 38.9343 29.9393 38.7691 29.8644C38.6039 29.7895
38.4539 29.6801 38.3278 29.5424C38.2016 29.4047 38.1016 29.2413 38.0336
29.0617C37.9657 28.8821 37.931 28.6897 37.9315 28.4956C37.9316 28.2622 37.9831
28.0323 38.0818 27.825L45.8231 11.601C45.9368 11.3601 46.1096 11.1578 46.3225
11.0165C46.5353 10.8752 46.78 10.8003 47.0296 10.8V10.8C47.279 10.7998 47.5236
10.8742 47.7365 11.0152C47.9494 11 [...]
-<path d="M78.0635 12.2203V28.6631C78.0635 29.0157 77.9343 29.3539 77.7044
29.6032C77.4745 29.8525 77.1628 29.9926 76.8376 29.9926C76.5125 29.9926 76.2008
29.8525 75.9709 29.6032C75.741 29.3539 75.6118 29.0157 75.6118
28.6631V16.6558L70.5304 25.2707C70.4236 25.5036 70.2579 25.6987 70.0526
25.8331C69.8472 25.9675 69.6109 26.0357 69.3711 26.0297C69.1366 26.0228 68.9082
25.9464 68.7107 25.809C68.5132 25.6715 68.3541 25.4781 68.2505 25.2498L63.1841
16.686V28.6631C63.1841 30.3884 60.7325 30.38 [...]
-<path d="M33.7302 28.7772C33.7308 29.0937 33.6161 29.3975 33.411
29.6226C33.2059 29.8476 32.9271 29.9756 32.6354 29.9787H20.8517C20.7061 29.9865
20.5606 29.963 20.4235 29.9096C20.2863 29.8562 20.1603 29.7739 20.0526
29.6675C19.9448 29.561 19.8576 29.4325 19.7958 29.2894C19.734 29.1463 19.699
28.9913 19.6926 28.8334C19.6862 28.6755 19.7087 28.5178 19.7587 28.3694C19.8087
28.221 19.8853 28.0847 19.9841 27.9685C20.0828 27.8523 20.2017 27.7584 20.3341
27.6922C20.4664 27.626 20.6095 27.5888 2 [...]
-<path d="M15.5469 24.1741C15.5469 29.222 10.9893 29.9787 8.27572
29.9787H1.12049C0.844136 29.9493 0.587767 29.8094 0.401263 29.5862C0.214759
29.3631 0.111459 29.0727 0.111459 28.7715C0.111459 28.4703 0.214759 28.1799
0.401263 27.9568C0.587767 27.7336 0.844136 27.5937 1.12049
27.5642H8.27572C11.4336 27.5642 13.0416 26.4303 13.0416 24.1858C13.0416 21.4267
10.2744 21.1333 9.08721 21.1333H1.12049C0.845648 21.1012 0.591439 20.9601
0.406729 20.737C0.222019 20.5139 0.119844 20.2247 0.119844 19. [...]
-<path d="M33.4491 19.8807C33.4493 20.0376 33.4211 20.193 33.366 20.338C33.311
20.4831 33.2301 20.6149 33.128 20.726C33.0259 20.8372 32.9047 20.9254 32.7712
20.9857C32.6377 21.046 32.4945 21.0772 32.3499 21.0775H21.1287C20.8442 21.0639
20.5755 20.9318 20.3786 20.7086C20.1817 20.4854 20.0718 20.1885 20.0718
19.8796C20.0718 19.5707 20.1817 19.2737 20.3786 19.0506C20.5755 18.8274 20.8442
18.6952 21.1287 18.6816H32.3478C32.4927 18.6816 32.6363 18.7127 32.7702
18.773C32.9041 18.8333 33.0257 18 [...]
-<path d="M19.7546 11.9992C19.7541 11.8423 19.782 11.6869 19.8368
11.5417C19.8917 11.3966 19.9723 11.2645 20.0742 11.1532C20.176 11.0418 20.2971
10.9533 20.4305 10.8928C20.5639 10.8322 20.707 10.8007 20.8517
10.8H32.6353C32.928 10.8 33.2087 10.9261 33.4156 11.1506C33.6225 11.375 33.7388
11.6794 33.7388 11.9968C33.7388 12.3142 33.6225 12.6186 33.4156 12.8431C33.2087
13.0675 32.928 13.1936 32.6353 13.1936H20.8517C20.5608 13.1905 20.2828 13.0636
20.0776 12.8401C19.8723 12.6166 19.7563 12.314 [...]
-<path d="M1.24733 41.4297C0.969562 41.2083 0.737114 40.9268 0.564656
40.6031C0.475959 40.445 0.448748 40.2552 0.488999 40.0753C0.52925 39.8954
0.633673 39.7402 0.779335 39.6438C0.813316 39.6207 0.84926 39.6013 0.886674
39.5856C1.02962 39.5176 1.1905 39.5081 1.33937 39.5591C1.48825 39.6101 1.61499
39.718 1.69601 39.8627C1.77506 40.0188 1.87651 40.1603 1.99656 40.2818C2.11293
40.4008 2.24982 40.4938 2.39939 40.5553C2.54896 40.6169 2.70826 40.6458 2.86815
40.6404C3.1342 40.6496 3.39622 40.5 [...]
-<path d="M15.5943 41.609C15.1866 41.3542 14.8584 40.9731 14.6518
40.5146C14.4185 39.9853 14.3038 39.4038 14.3169 38.8173V34.9848C14.3169 34.7995
14.3848 34.6219 14.5056 34.4909C14.6263 34.3599 14.7902 34.2863 14.961
34.2863V34.2863C15.1318 34.2863 15.2956 34.3599 15.4164 34.4909C15.5372 34.6219
15.605 34.7995 15.605 34.9848V38.9034C15.5856 39.3562 15.7149 39.8017 15.97
40.1607C16.0997 40.308 16.255 40.4261 16.4269 40.5083C16.5988 40.5905 16.7839
40.6351 16.9717 40.6397C17.1596 40.6442 17 [...]
-<path d="M30.143 34.2793C30.3457 34.2788 30.5437 34.3455 30.7105
34.4703C30.8774 34.5951 31.0052 34.7722 31.0768 34.9778L32.6783
39.574H32.7556L34.3528 34.9801C34.4252 34.775 34.5532 34.5985 34.7199
34.4739C34.8866 34.3492 35.0842 34.2822 35.2867 34.2816V34.2816C35.5514 34.2816
35.8053 34.3957 35.9925 34.5987C36.1797 34.8018 36.2849 35.0772 36.2849
35.3643V35.3643V41.12C36.2849 41.3053 36.2171 41.4829 36.0963 41.6139C35.9755
41.7449 35.8117 41.8185 35.6409 41.8185C35.4701 41.8185 35.3062 [...]
-<path d="M46.8449 34.2793C47.0476 34.2792 47.2454 34.3459 47.4122
34.4707C47.579 34.5955 47.7069 34.7723 47.7788 34.9778L49.3803
39.5763H49.4576L51.0591 34.9801C51.131 34.7747 51.2588 34.5978 51.4256
34.473C51.5924 34.3483 51.7903 34.2815 51.9929 34.2816H52.0037C52.2684 34.2816
52.5223 34.3957 52.7095 34.5987C52.8967 34.8018 53.0019 35.0772 53.0019
35.3643V35.3643V41.12C53.0019 41.3053 52.9341 41.4829 52.8133 41.6139C52.6925
41.7449 52.5287 41.8185 52.3579 41.8185V41.8185C52.1871 41.8185 [...]
-<path d="M63.2035 34.2793C63.375 34.2805 63.5393 34.3541 63.6615
34.4845C63.7838 34.6149 63.8543 34.7919 63.8583 34.9778V41.0967C63.8632 41.1901
63.8511 41.2837 63.8227 41.372C63.7943 41.4604 63.7501 41.5418 63.6927
41.6116C63.6353 41.6815 63.5658 41.7384 63.4881 41.7791C63.4104 41.8197 63.3261
41.8434 63.24 41.8488C63.1539 41.8541 63.0676 41.841 62.9861 41.8102C62.9047
41.7794 62.8296 41.7315 62.7652 41.6693C62.7008 41.607 62.6484 41.5316 62.6109
41.4473C62.5734 41.3631 62.5515 41.2716 [...]
-<path d="M74.8111 35.6272H73.4909C73.4091 35.6327 73.3272 35.6206 73.2497
35.5917C73.1723 35.5627 73.1009 35.5175 73.0396 35.4586C72.9783 35.3996 72.9283
35.3282 72.8925 35.2482C72.8567 35.1683 72.8358 35.0815 72.831 34.9929C72.8262
34.9042 72.8376 34.8153 72.8645 34.7314C72.8914 34.6475 72.9334 34.5702 72.9879
34.5039C73.0424 34.4376 73.1084 34.3836 73.1822 34.345C73.256 34.3064 73.3361
34.284 73.4179 34.2791C73.4422 34.2768 73.4666 34.2768 73.4909
34.2791H77.441C77.5227 34.2736 77.6047 [...]
-</g>
-<path fill-rule="evenodd" clip-rule="evenodd" d="M82.1334 0.945591C79.3918
0.945591 77.1693 3.27405 77.1693 6.14634C77.1693 9.01864 79.3918 11.3471
82.1334 11.3471C84.875 11.3471 87.0975 9.01864 87.0975 6.14634C87.0975 3.27405
84.875 0.945591 82.1334 0.945591ZM76.2667 6.14634C76.2667 2.75181 78.8933 0
82.1334 0C85.3735 0 88.0001 2.75181 88.0001 6.14634C88.0001 9.54087 85.3735
12.2927 82.1334 12.2927C78.8933 12.2927 76.2667 9.54087 76.2667
6.14634ZM82.1334 4.25508C82.4657 4.25508 82.7351 [...]
-<defs>
-<clipPath id="clip0_22_6">
-<rect width="78.1" height="31.2" fill="white" transform="translate(0 10.8)"/>
-</clipPath>
-</defs>
-</svg>
diff --git
a/playground/frontend/lib/components/summit_banner/summit_banner_button.dart
b/playground/frontend/lib/components/banner/banner_button.dart
similarity index 86%
rename from
playground/frontend/lib/components/summit_banner/summit_banner_button.dart
rename to playground/frontend/lib/components/banner/banner_button.dart
index d82d35c234b..78e7002cf8f 100644
--- a/playground/frontend/lib/components/summit_banner/summit_banner_button.dart
+++ b/playground/frontend/lib/components/banner/banner_button.dart
@@ -19,11 +19,11 @@
import 'package:aligned_dialog/aligned_dialog.dart';
import 'package:flutter/material.dart';
import 'package:flutter_svg/flutter_svg.dart';
-import 'package:playground/components/summit_banner/banner_description.dart';
+import 'package:playground/components/banner/banner_description.dart';
import 'package:playground/constants/assets.dart';
-class SummitBanner extends StatelessWidget {
- const SummitBanner({Key? key}) : super(key: key);
+class BannerButton extends StatelessWidget {
+ const BannerButton({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
@@ -38,7 +38,7 @@ class SummitBanner extends StatelessWidget {
barrierColor: Colors.transparent,
);
},
- child: SvgPicture.asset(kSummitBannerAsset),
+ child: SvgPicture.asset(kBeamIconAsset),
);
}
}
diff --git
a/playground/frontend/lib/components/summit_banner/banner_description.dart
b/playground/frontend/lib/components/banner/banner_description.dart
similarity index 89%
rename from
playground/frontend/lib/components/summit_banner/banner_description.dart
rename to playground/frontend/lib/components/banner/banner_description.dart
index 5d59d74771e..ab9ccfd5179 100644
--- a/playground/frontend/lib/components/summit_banner/banner_description.dart
+++ b/playground/frontend/lib/components/banner/banner_description.dart
@@ -26,13 +26,11 @@ import 'package:url_launcher/url_launcher.dart';
const kBannerTopPadding = 60.0;
const kDescriptionLineHeight = 1.5;
-const kBannerTitle = 'Beam Summit';
-const kBannerDescription1 =
- 'Join the Apache Beam community July 18th-20th for ';
-const kBannerDescription2 = 'Beam Summit 2022';
-const kBannerDescription3 =
- ' to learn more about Beam and share your expertise.';
-const kSummitUrl = 'https://2022.beamsummit.org';
+const kBannerTitle = '';
+const kBannerDescription1 = '';
+const kHyperlinkText = '';
+const kBannerDescription2 = '';
+const kBannerUrl = '';
class BannerDescription extends StatelessWidget {
const BannerDescription({Key? key}) : super(key: key);
@@ -76,10 +74,10 @@ class BannerDescription extends StatelessWidget {
mouseCursor: SystemMouseCursors.click,
recognizer: TapGestureRecognizer()
..onTap = () async {
- launchUrl(Uri.parse(kSummitUrl));
+ launchUrl(Uri.parse(kBannerUrl));
}),
TextSpan(
- text: kBannerDescription3,
+ text: kHyperlinkText,
style: TextStyle(
color: ThemeColors.of(context).textColor,
height: kDescriptionLineHeight,
diff --git a/playground/frontend/lib/constants/assets.dart
b/playground/frontend/lib/constants/assets.dart
index b7c8f218bb7..796a97daa87 100644
--- a/playground/frontend/lib/constants/assets.dart
+++ b/playground/frontend/lib/constants/assets.dart
@@ -34,7 +34,6 @@ const kLinkIconAsset = 'link.svg';
const kDragHorizontalIconAsset = 'drag_horizontal.svg';
const kDragVerticalIconAsset = 'drag_vertical.svg';
const kMultifileIconAsset = 'multifile.svg';
-const kSummitBannerAsset = 'summit_banner.svg';
// notifications icons
const kErrorNotificationIconAsset = 'error_notification.svg';
diff --git a/playground/frontend/lib/pages/playground/playground_page.dart
b/playground/frontend/lib/pages/playground/playground_page.dart
index 5cb7a7d8962..75725c2d59b 100644
--- a/playground/frontend/lib/pages/playground/playground_page.dart
+++ b/playground/frontend/lib/pages/playground/playground_page.dart
@@ -18,7 +18,6 @@
import 'package:flutter/material.dart';
import 'package:playground/components/logo/logo_component.dart';
-import 'package:playground/components/summit_banner/summit_banner_button.dart';
import
'package:playground/components/toggle_theme_button/toggle_theme_button.dart';
import 'package:playground/constants/sizes.dart';
import 'package:playground/modules/actions/components/new_example_action.dart';
@@ -84,7 +83,7 @@ class PlaygroundPage extends StatelessWidget {
);
},
),
- actions: const [SummitBanner(), ToggleThemeButton(),
MoreActions()],
+ actions: const [ToggleThemeButton(), MoreActions()],
),
body: Column(
children: [
