[ 
https://issues.apache.org/jira/browse/BEAM-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962242#comment-15962242
 ] 

Jean-Baptiste Onofré commented on BEAM-1922:
--------------------------------------------

Yes, it's the easiest path to start with.

> DataSource in JdbcIO is not closed
> ----------------------------------
>
>                 Key: BEAM-1922
>                 URL: https://issues.apache.org/jira/browse/BEAM-1922
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>
> The line below is not closed properly, 
> {code}
> BasicDataSource basicDataSource = new BasicDataSource();
> {code}
> It's a potential issue for the other usage, although {{DataSource}} doesn't 
> have a {{close()}} method.
> {code}
> public static DataSourceConfiguration create(DataSource dataSource)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to