[ https://issues.apache.org/jira/browse/BEAM-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Kirpichov reassigned BEAM-1914: -------------------------------------- Assignee: Eugene Kirpichov > XML IO should comply with PTransform style guide > ------------------------------------------------ > > Key: BEAM-1914 > URL: https://issues.apache.org/jira/browse/BEAM-1914 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Eugene Kirpichov > Assignee: Eugene Kirpichov > Labels: backward-incompatible, starter > > Currently we have XmlSource and XmlSink in the Java SDK. They violate the > PTransform style guide in several respects: > - They should be grouped into an XmlIO class with read() and write() verbs, > like all the other similar connectors > - The source/sink classes should be made private or package-local > - Should get rid of XmlSink.Bound - XmlSink itself should inherit from > FileBasedSink > - Could optionally benefit from AutoValue > See e.g. the PR with BigQuery fixes https://github.com/apache/beam/pull/2149 -- This message was sent by Atlassian JIRA (v6.3.15#6346)