[
https://issues.apache.org/jira/browse/BEAM-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aviem Zur updated BEAM-2001:
----------------------------
Description:
Currently, {{PAssert}} assertions may not happen and tests will pass while
silently hiding issues.
For {{ValidatesRunner}} tests to truly validate a runner supports the model we
need to verify the {{PAssert}} assertions actually ran.
See [dev list
discussion|https://lists.apache.org/thread.html/9e6b9e6a21d2a657a1dd293b8cc8497c76a8a66fa3a1358733c02101@%3Cdev.beam.apache.org%3E].
In order to reduce duplication, for runners which support metrics we could
verify this in {{TestPipeline}}, removing the need for the runner itself to
make this assertion (See https://issues.apache.org/jira/browse/BEAM-1763).
was:
Currently, {{PAssert}} assertions may not happen and tests will pass while
silently hiding issues.
For {{ValidatesRunner}} tests to truly validate a runner supports the model we
need to verify the {{PAssert}} assertions actually ran.
See [dev list
discussion|https://lists.apache.org/thread.html/9e6b9e6a21d2a657a1dd293b8cc8497c76a8a66fa3a1358733c02101@%3Cdev.beam.apache.org%3E].
In order to reduce duplication, for runners which support metrics we could
verify this in {{TestPipeline}}, removing the need for the runner itself to
make this assertion.
> Verify PAssert execution in all runners
> ---------------------------------------
>
> Key: BEAM-2001
> URL: https://issues.apache.org/jira/browse/BEAM-2001
> Project: Beam
> Issue Type: Test
> Components: runner-core
> Reporter: Aviem Zur
> Assignee: Kenneth Knowles
> Priority: Blocker
>
> Currently, {{PAssert}} assertions may not happen and tests will pass while
> silently hiding issues.
> For {{ValidatesRunner}} tests to truly validate a runner supports the model
> we need to verify the {{PAssert}} assertions actually ran.
> See [dev list
> discussion|https://lists.apache.org/thread.html/9e6b9e6a21d2a657a1dd293b8cc8497c76a8a66fa3a1358733c02101@%3Cdev.beam.apache.org%3E].
> In order to reduce duplication, for runners which support metrics we could
> verify this in {{TestPipeline}}, removing the need for the runner itself to
> make this assertion (See https://issues.apache.org/jira/browse/BEAM-1763).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
