[ https://issues.apache.org/jira/browse/BEAM-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975855#comment-15975855 ]
ASF GitHub Bot commented on BEAM-1871: -------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/beam/pull/2606 [BEAM-1871] Remove DeterministicStandardCoder Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This isn't a particularly useful Coder. It has no defined methods other than verifyDeterministic, which has an empty implementation. Additionally, there are no guarantees that a DeterministicStandardCoder is determinsitic. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/beam so_many_custom_coders Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2606.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2606 ---- commit a52186cdd308f155eae34ca287b8bbaf9e95afc9 Author: Thomas Groh <tg...@google.com> Date: 2017-04-20T00:58:58Z Remove DeterministicStandardCoder This isn't a particularly useful Coder. It has no defined methods other than verifyDeterministic, which has an empty implementation. Additionally, there are no guarantees that a DeterministicStandardCoder is determinsitic. ---- > Thin Java SDK Core > ------------------ > > Key: BEAM-1871 > URL: https://issues.apache.org/jira/browse/BEAM-1871 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Daniel Halperin > Assignee: Luke Cwik > Fix For: First stable release > > > Before first stable release we need to thin out {{sdk-java-core}} module. > Some candidates for removal, but not a non-exhaustive list: > {{sdk/io}} > * anything BigQuery related > * anything PubSub related > * everything Protobuf related > * TFRecordIO > * XMLSink > {{sdk/util}} > * Everything GCS related > * Everything Backoff related > * Everything Google API related: ResponseInterceptors, RetryHttpBackoff, etc. > * Everything CloudObject-related > * Pubsub stuff > {{sdk/coders}} > * JAXBCoder > * TableRowJsoNCoder -- This message was sent by Atlassian JIRA (v6.3.15#6346)