Repository: beam Updated Branches: refs/heads/master e44918881 -> 8be1dacab
[BEAM-1992] Move Count.PerElement javadoc to a public place Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/eb56f993 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/eb56f993 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/eb56f993 Branch: refs/heads/master Commit: eb56f9934726d51c07f1703caaa01cb80b27cc56 Parents: e449188 Author: wtanaka.com <wtan...@yahoo.com> Authored: Mon Apr 17 21:57:10 2017 -1000 Committer: Eugene Kirpichov <kirpic...@google.com> Committed: Thu Apr 20 15:12:01 2017 -0700 ---------------------------------------------------------------------- .../org/apache/beam/sdk/transforms/Count.java | 26 ++++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/eb56f993/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java index fd91430..abda1c6 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java @@ -71,24 +71,17 @@ public class Count { } /** - * Returns a {@link PerElement Count.PerElement} {@link PTransform} that counts the number of - * occurrences of each element in its input {@link PCollection}. + * Returns a {@link PTransform} that counts the number of occurrences of each element + * in its input {@link PCollection}. * - * <p>See {@link PerElement Count.PerElement} for more details. - */ - public static <T> PTransform<PCollection<T>, PCollection<KV<T, Long>>> perElement() { - return new PerElement<>(); - } - - /** - * {@code Count.PerElement<T>} takes a {@code PCollection<T>} and returns a + * <p>The returned {@code PTransform} takes a {@code PCollection<T>} and returns a * {@code PCollection<KV<T, Long>>} representing a map from each distinct element of the input * {@code PCollection} to the number of times that element occurs in the input. Each key in the * output {@code PCollection} is unique. * - * <p>This transform compares two values of type {@code T} by first encoding each element using - * the input {@code PCollection}'s {@code Coder}, then comparing the encoded bytes. Because of - * this, the input coder must be deterministic. + * <p>The returned transform compares two values of type {@code T} by first encoding each + * element using the input {@code PCollection}'s {@code Coder}, then comparing the encoded + * bytes. Because of this, the input coder must be deterministic. * (See {@link org.apache.beam.sdk.coders.Coder#verifyDeterministic()} for more detail). * Performing the comparison in this manner admits efficient parallel evaluation. * @@ -101,6 +94,13 @@ public class Count { * PCollection<KV<String, Long>> wordCounts = * words.apply(Count.<String>perElement()); * } </pre> + */ + public static <T> PTransform<PCollection<T>, PCollection<KV<T, Long>>> perElement() { + return new PerElement<>(); + } + + /** + * Private implementation of {@link #perElement()}. * * @param <T> the type of the elements of the input {@code PCollection}, and the type of the keys * of the output {@code PCollection}
