[
https://issues.apache.org/jira/browse/BEAM-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977817#comment-15977817
]
ASF GitHub Bot commented on BEAM-1428:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/2620
[BEAM-1428] KinesisIO should comply with PTransform style guide
https://issues.apache.org/jira/browse/BEAM-1428
There's lots of other issues in KinesisIO, but this at least brings its API
surface to a level where making it more style-compliant will not require
backward-incompatible changes.
R: @jbonofre
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam kinesis-style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2620.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2620
----
commit 65b5b0f09dd9a89871a2793e1d8da59f6f45d5a4
Author: Eugene Kirpichov <kirpic...@google.com>
Date: 2017-04-20T23:48:23Z
[BEAM-1428] KinesisIO should comply with PTransform style guide
----
> KinesisIO should comply with PTransform style guide
> ---------------------------------------------------
>
> Key: BEAM-1428
> URL: https://issues.apache.org/jira/browse/BEAM-1428
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Reporter: Eugene Kirpichov
> Labels: backward-incompatible, starter
>
> Suggested changes:
> - KinesisIO.Read should be a PTransform itself
> - It should have builder methods .withBlah() for setting the parameters,
> instead of the current somewhat strange combination of the from() factory
> methods and the using() methods
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
