[
https://issues.apache.org/jira/browse/BEAM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977991#comment-15977991
]
ASF GitHub Bot commented on BEAM-1022:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2626
[BEAM-1022] Use Structural Value when comparing Window(AndTrigger)
Namespaces
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
This makes sure we don't use a potentially default equals method and
instead compare based on the Coder, which is how Beam defines equality.
Improve GlobalWindow and IntervalWindow structuralValue methods.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam structural_values_state_namespaces
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2626.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2626
----
commit 4915efe8be7b9a2a4cbfe83449e23132e658ac41
Author: Thomas Groh <tg...@google.com>
Date: 2017-04-21T03:00:07Z
Coder.structuralValue(T) should never throw
In the worst case, encoding to a byte array should never fail due to IO.
commit 74455ddb8a9c43230efb5058255cb1e5756000ae
Author: Thomas Groh <tg...@google.com>
Date: 2017-04-21T03:00:55Z
Use Structural Value when comparing Window(AndTrigger) Namespaces
This makes sure we don't use a potentially default equals method and
instead compare based on the Coder, which is how Beam defines equality.
Improve GlobalWindow and IntervalWindow structuralValue methods.
----
> WindowNamespace and WindowAndTriggerNamespace should not use Java object
> equality when comparing windows
> --------------------------------------------------------------------------------------------------------
>
> Key: BEAM-1022
> URL: https://issues.apache.org/jira/browse/BEAM-1022
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Thomas Groh
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
