[ 
https://issues.apache.org/jira/browse/BEAM-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Groh resolved BEAM-1860.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Not applicable

This is fixed as part of the broader push to get a meaningful Coder Hierarchy.

> SerializableCoder should not extend DeterministicStandardCoder
> --------------------------------------------------------------
>
>                 Key: BEAM-1860
>                 URL: https://issues.apache.org/jira/browse/BEAM-1860
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 0.6.0
>            Reporter: Wesley Tanaka
>            Assignee: Thomas Groh
>             Fix For: Not applicable
>
>
> Not sure if this is just a doc bug, but:
> https://beam.apache.org/documentation/sdks/javadoc/0.6.0/org/apache/beam/sdk/coders/SerializableCoder.html
>  says:
> SerializableCoder does not guarantee a deterministic encoding, as Java 
> serialization may produce different binary encodings for two equivalent 
> objects.
> Yet 
> https://beam.apache.org/documentation/sdks/javadoc/0.6.0/org/apache/beam/sdk/coders/DeterministicStandardCoder.html
>  says:
> A DeterministicStandardCoder is a StandardCoder that is deterministic, in the 
> sense that for objects considered equal according to Object.equals(Object), 
> the encoded bytes are also equal.
> These sound like they conflict, and thus that SerializableCoder should not 
> extend DeterministicStandardCoder



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to