[
https://issues.apache.org/jira/browse/BEAM-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983591#comment-15983591
]
ASF GitHub Bot commented on BEAM-2051:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2680
[BEAM-2051] Remove all methods from PCollectionView
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
Cast to SimplePCollectionView everywhere a method is used.
PCollectionView is a marker interface. Runners can expect to
always recieve a subclass of SimplePCollectionView, and cast to it when
methods are required.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam view_as_marker
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2680
----
commit 8af055fbb529900cd525a344a4b1486981bdd665
Author: Thomas Groh <tg...@google.com>
Date: 2017-04-21T16:46:28Z
Remove all methods from PCollectionView
Cast to SimplePCollectionView everywhere a method is used.
PCollectionView is a marker interface. Runners can expect to
always recieve a subclass of SimplePCollectionView, and cast to it when
methods are required.
----
> Reduce scope of the PCollectionView interface
> ---------------------------------------------
>
> Key: BEAM-2051
> URL: https://issues.apache.org/jira/browse/BEAM-2051
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Fix For: First stable release
>
>
> Users should only ever use a PCollectionView class as a token to access a
> view. A Runner can cast down to a more expressive type if required.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
