This is an automated email from the ASF dual-hosted git repository.

damccorm pushed a commit to branch users/damccorm/image_cleaner
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/users/damccorm/image_cleaner 
by this push:
     new 519e49d1942 Better logging + actually fail the second time
519e49d1942 is described below

commit 519e49d1942694dc86ae703f54d936fdd98e5a0e
Author: Danny McCormick <dannymccorm...@google.com>
AuthorDate: Tue Aug 8 16:35:17 2023 -0400

    Better logging + actually fail the second time
---
 .test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh 
b/.test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh
index ca2b08dfb8a..eb3acb809ff 100755
--- a/.test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh
+++ b/.test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh
@@ -78,9 +78,10 @@ for image_name in ${IMAGE_NAMES[@]}; do
 
   # Some images may not be successfully deleted the first time due to 
flakiness or having a dependency that hasn't been deleted yet.
   RETRY_DELETE=("${FAILED_TO_DELETE[@]}")
+  echo "Failed to delete the following images: ${FAILED_TO_DELETE}. Retrying 
each of them."
   for current in $RETRY_DELETE; do
     echo "Trying again to delete image ${image_name}@"${current}". Command: 
gcloud container images delete ${image_name}@"${current}" --force-delete-tags 
-q"
-    gcloud container images delete ${image_name}@"${current}" 
--force-delete-tags -q || FAILED_TO_DELETE+="${current} "
+    gcloud container images delete ${image_name}@"${current}" 
--force-delete-tags -q
   done
 done
 

Reply via email to