[ https://issues.apache.org/jira/browse/BEAM-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985649#comment-15985649 ]
ASF GitHub Bot commented on BEAM-1316: -------------------------------------- GitHub user sb2nov reopened a pull request: https://github.com/apache/beam/pull/2715 [BEAM-1316] start bundle should not output any elements Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- R: @chamikaramj @robertwb PTAL You can merge this pull request into a Git repository by running: $ git pull https://github.com/sb2nov/beam BEAM-1316-start-bundle-no-output Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2715.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2715 ---- commit 007945fb2ff9e3cd4332b1d93bd375005aba5f7d Author: Sourabh Bajaj <sourabhba...@google.com> Date: 2017-04-26T22:09:03Z [BEAM-1316] start bundle should not output any elements ---- > DoFn#startBundle should not be able to output > --------------------------------------------- > > Key: BEAM-1316 > URL: https://issues.apache.org/jira/browse/BEAM-1316 > Project: Beam > Issue Type: Bug > Components: sdk-java-core, sdk-py > Reporter: Thomas Groh > Assignee: Thomas Groh > Fix For: First stable release > > > While within startBundle and finishBundle, the window in which elements are > output is not generally defined. Elements must always be output from within a > windowed context, or the {{WindowFn}} used by the {{PCollection}} may not > operate appropriately. > startBundle and finishBundle are suitable for operational duties, similarly > to {{setup}} and {{teardown}}, but within the scope of some collection of > input elements. This includes actions such as clearing field state within a > DoFn and ensuring all live RPCs complete successfully before committing > inputs. > Sometimes it might be reasonable to output from {{@FinishBundle}} but it is > hard to imagine a situation where output from {{@StartBundle}} is useful in a > way that doesn't seriously abuse things. -- This message was sent by Atlassian JIRA (v6.3.15#6346)