[
https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990737#comment-15990737
]
ASF GitHub Bot commented on BEAM-1676:
--------------------------------------
GitHub user staslev opened a pull request:
https://github.com/apache/beam/pull/2799
[BEAM-1676] Internalize ClassPath from Guava 21.0.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/staslev/beam
BEAM-1676-api-surface-tests-fail-with-spaces-in-dir-name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2799
----
commit 0624a70bd824c82219107e1a1594aafe7383e993
Author: Stas Levin <stasle...@apache.org>
Date: 2017-04-30T10:56:40Z
[BEAM-1676] Internalize ClassPath from Guava 21.0 to fix the failures
related to having whitespaces in resource names.
----
> SdkCoreApiSurfaceTest Failed When Directory Contains Space
> ----------------------------------------------------------
>
> Key: BEAM-1676
> URL: https://issues.apache.org/jira/browse/BEAM-1676
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Mark Liu
> Assignee: Stas Levin
>
> Test failed if build directory contains space. For example: "~/dir with
> space/beam/..."
> The failure happened on Jenkins and can be reproduced from local.
> GcpApiSurfaceTest may have same problem.
> error is:
> {code}
> Failed tests:
> SdkCoreApiSurfaceTest.testSdkApiSurface:59
> Expected: API surface to include only:
> Classes in package "org.apache.beam"
> Classes in package "com.google.api.client"
> Classes in package "com.google.api.services.bigquery"
> Classes in package "com.google.api.services.cloudresourcemanager"
> Classes in package "com.google.api.services.pubsub"
> Classes in package "com.google.api.services.storage"
> Classes in package "com.google.auth"
> Classes in package "com.google.protobuf"
> Classes in package "com.fasterxml.jackson.annotation"
> Classes in package "com.fasterxml.jackson.core"
> Classes in package "com.fasterxml.jackson.databind"
> Classes in package "org.apache.avro"
> Classes in package "org.hamcrest"
> Classes in package "org.codehaus.jackson"
> Classes in package "org.joda.time"
> Classes in package "org.junit"
>
> but: The following white-listed scopes did not have matching classes on
> the API surface:
> No Classes in package "com.fasterxml.jackson.annotation"
> No Classes in package "com.fasterxml.jackson.core"
> No Classes in package "com.fasterxml.jackson.databind"
> No Classes in package "com.google.api.client"
> No Classes in package "com.google.api.services.bigquery"
> No Classes in package "com.google.api.services.cloudresourcemanager"
> No Classes in package "com.google.api.services.pubsub"
> No Classes in package "com.google.api.services.storage"
> No Classes in package "com.google.auth"
> No Classes in package "com.google.protobuf"
> No Classes in package "org.apache.avro"
> No Classes in package "org.apache.beam"
> No Classes in package "org.codehaus.jackson"
> No Classes in package "org.hamcrest"
> No Classes in package "org.joda.time"
> No Classes in package "org.junit"
> {code}
> Job link from Jenkins:
> https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/
> One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project
> directory.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
