This is an automated email from the ASF dual-hosted git repository. robertwb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push: new d2db322c081 Fix ISM-expecting tests by explicilty requisting random access. (#31149) d2db322c081 is described below commit d2db322c081be810c0f756b6dbabc2208ffedb35 Author: Robert Bradshaw <rober...@gmail.com> AuthorDate: Wed May 1 11:24:02 2024 -0700 Fix ISM-expecting tests by explicilty requisting random access. (#31149) --- .../beam/runners/dataflow/DataflowPipelineTranslatorTest.java | 4 +++- .../apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java index 3b2c7aa0d8e..0f3451bbb78 100644 --- a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java +++ b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java @@ -948,7 +948,9 @@ public class DataflowPipelineTranslatorTest implements Serializable { Pipeline pipeline = Pipeline.create(options); final PCollectionView<List<Integer>> view = - pipeline.apply("CreateSideInput", Create.of(11, 13, 17, 23)).apply(View.asList()); + pipeline + .apply("CreateSideInput", Create.of(11, 13, 17, 23)) + .apply(View.<Integer>asList().withRandomAccess()); pipeline .apply("CreateMainInput", Create.of(29, 31)) diff --git a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java index 42bc9eb5389..0ce92f9d932 100644 --- a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java +++ b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java @@ -678,7 +678,9 @@ public class IsmSideInputReaderTest { KV.of(2L, valueInGlobalWindow(62L))); final PCollectionView<List<Long>> view = - Pipeline.create().apply(Create.empty(VarLongCoder.of())).apply(View.asList()); + Pipeline.create() + .apply(Create.empty(VarLongCoder.of())) + .apply(View.<Long>asList().withRandomAccess()); Source sourceA = initInputFile(fromKvsForList(firstElements), ismCoder); Source sourceB = initInputFile(fromKvsForList(secondElements), ismCoder); @@ -736,7 +738,7 @@ public class IsmSideInputReaderTest { Pipeline.create() .apply(Create.empty(VarLongCoder.of())) .apply(Window.into(FixedWindows.of(Duration.millis(10)))) - .apply(View.asList()); + .apply(View.<Long>asList().withRandomAccess()); Source sourceA = initInputFile(fromKvsForList(concat(firstElements, secondElements)), ismCoder); Source sourceB = initInputFile(fromKvsForList(thirdElements), ismCoder);