[ https://issues.apache.org/jira/browse/BEAM-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991974#comment-15991974 ]
ASF GitHub Bot commented on BEAM-59: ------------------------------------ GitHub user dhalperi opened a pull request: https://github.com/apache/beam/pull/2814 [BEAM-59] Minor changes that can be separated out from big PR All these are minor changes, correct at HEAD, and standalone from #2779 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dhalperi/beam test-cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2814.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2814 ---- commit dbfe24b408c0ebeb003804676484214640ea10df Author: Dan Halperin <dhalp...@google.com> Date: 2017-05-02T01:43:23Z [BEAM-59] Core tests: stop using gs:// paths Local filesystem is just as good an example, and in the future these may break because GCS filesystem is not present in sdks/java/core. commit 6b0fa09eb45dfe51d9d93112deea79ff6578e167 Author: Dan Halperin <dhalp...@google.com> Date: 2017-05-02T01:46:24Z [BEAM-59] TFRecordIOTest: cleanup 1. Shrink file size slightly to reduce test time. 2. Switch from relative to absolute local file paths, because in the future this distinction will matter. commit 7a02eab9f70f962499101c039a78bcafc2725d3e Author: Dan Halperin <dhalp...@google.com> Date: 2017-05-02T01:49:28Z [BEAM-59] DataflowRunnerTests: configure FileSystems in test This enables the test to use gs:// URIs with the FileSystems API commit 5ac3cff9b774d1e0c3ce7ee91bfd8aa23cd2dc27 Author: Dan Halperin <dhalp...@google.com> Date: 2017-05-02T01:54:40Z [BEAM-59] AvroIOTest: use absolute paths for display data This is future-proofing against eventual conversion to FileSystems API in which all paths are absolute ---- > Switch from IOChannelFactory to FileSystems > ------------------------------------------- > > Key: BEAM-59 > URL: https://issues.apache.org/jira/browse/BEAM-59 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core, sdk-java-gcp > Reporter: Daniel Halperin > Assignee: Daniel Halperin > Fix For: First stable release > > > Right now, FileBasedSource and FileBasedSink communication is mediated by > IOChannelFactory. There are a number of issues: > * Global configuration -- e.g., all 'gs://' URIs use the same credentials. > This should be per-source/per-sink/etc. > * Supported APIs -- currently IOChannelFactory is in the "non-public API" > util package and subject to change. We need users to be able to add new > backends ('s3://', 'hdfs://', etc.) directly, without fear that they will be > broken. > * Per-backend features: e.g., creating buckets in GCS/s3, setting expiration > time, etc. > Updates: > Design docs posted on dev@ list: > Part 1: IOChannelFactory Redesign: > https://docs.google.com/document/d/11TdPyZ9_zmjokhNWM3Id-XJsVG3qel2lhdKTknmZ_7M/edit# > Part 2: Configurable BeamFileSystem: > https://docs.google.com/document/d/1-7vo9nLRsEEzDGnb562PuL4q9mUiq_ZVpCAiyyJw8p8/edit#heading=h.p3gc3colc2cs -- This message was sent by Atlassian JIRA (v6.3.15#6346)