[
https://issues.apache.org/jira/browse/BEAM-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993557#comment-15993557
]
ASF GitHub Bot commented on BEAM-1340:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2839
[BEAM-1340,BEAM-1345] Move WindowingStrategy from util to values
WindowingStrategy is a property on PCollection that transform authors
regularly mess with. It is part of the public API.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
I don't have a strong feeling that any of the public methods need to be
marked `@Internal`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam WindowingStrategy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2839.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2839
----
commit 49ca126a0d372500a31ba22bd6d26d9110fad6ce
Author: Kenneth Knowles <k...@google.com>
Date: 2017-05-02T18:41:40Z
Move WindowingStrategy from util to values
WindowingStrategy is a property on PCollection that transform authors
regularly mess with. It is part of the public API.
----
> Remove or make private public bits of the SDK that shouldn't be public
> ----------------------------------------------------------------------
>
> Key: BEAM-1340
> URL: https://issues.apache.org/jira/browse/BEAM-1340
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-java-extensions
> Reporter: Kenneth Knowles
> Priority: Blocker
> Labels: backward-incompatible
> Fix For: First stable release
>
>
> This JIRA is for the many small changes that do not merit their own JIRA
> towards getting the SDK's API surface right. For example, removal of
> `DoFn.InputProvider` and `DoFn.OutputReceiver`.
> While the above is not quite backwards incompatible, succeeding at this task
> surely will be.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
