GitHub user xumingming opened a pull request:

    https://github.com/apache/beam/pull/2886

    [BEAM-2151]Fix inconsistent mapping for SQL FLOAT

    This pull request is mainly to fix the SQL FLOAT mapping, previously it is 
mapped to Float in `BeamSQLRow`, but mapped to `Double` in `BeamSQLRowCoder`, 
now we consistently map SQL FLOAT to java Float.
    
    When try to unit test this, found another bug in BeamSQLRow: the VARCHAR 
field is not encode/decoded correctly(mainly because OUTTER Context vs NESTED 
Context), so fixed this bug at the same time.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xumingming/beam BEAM-2151

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2886
    
----
commit 02ffb848cf536cf631696f68051fecded2907931
Author: James Xu <xumingmi...@gmail.com>
Date:   2017-05-04T03:44:14Z

    Fix inconsistent mapping for SQL FLOAT

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to