[ 
https://issues.apache.org/jira/browse/BEAM-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998597#comment-15998597
 ] 

ASF GitHub Bot commented on BEAM-2183:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2916

    [BEAM-2183] Archetypes: fix build order

    R: @davorbonaci 
    CC: @jbonofre 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam maven-archetype-build-order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2916
    
----
commit e8584253a9036f10e98666cb281e4bfa3ef362f5
Author: Dan Halperin <dhalp...@google.com>
Date:   2017-05-05T16:45:50Z

    Archetypes: fix build order

----


> Maven-archetypes should depend on all Beam modules that their sources compile 
> against
> -------------------------------------------------------------------------------------
>
>                 Key: BEAM-2183
>                 URL: https://issues.apache.org/jira/browse/BEAM-2183
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>             Fix For: First stable release
>
>
> The archetypes in {{sdks/java/maven-archetypes/*}} compile and run tests for 
> source code that depends on various Beam modules. The dependencies are 
> reflected in the *inner* pom.xml inside 
> {{src/main/resources/archetype-resources/pom.xml}}.
> The outer module needs to have the same Beam dependencies to force the Maven 
> Reactor build order to process those modules first. Otherwise, a simple run 
> of {{mvn install}} (e.g.,) , even without parallelism, may run the 
> {{maven-archetypes}} step before it install the dependent modules. This means 
> that the code may run against a previous nightly snapshot or other 
> non-up-to-date-copy of those modules.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to