[
https://issues.apache.org/jira/browse/BEAM-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999235#comment-15999235
]
ASF GitHub Bot commented on BEAM-1871:
--------------------------------------
GitHub user vikkyrk opened a pull request:
https://github.com/apache/beam/pull/2937
[BEAM-1871] Remote google api client from sdks/core
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
- Remove usage of google api client base64 encoding
- Copy google api client versions of BackOff, BackOffUtils and Sleeper
classes into sdks/core.
- Use an adapters to convert from beam to google api client interfaces.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vikkyrk/incubator-beam thin_sdk_core
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2937.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2937
----
commit 10bfb1b97b8577f177e3add165477bdbe1b42bf6
Author: Vikas Kedigehalli <vika...@google.com>
Date: 2017-05-06T02:33:45Z
Use guava Base64 encoding instead of google api client
commit 11074ebd029e3f76a79b168411a569157d2c28c6
Author: Vikas Kedigehalli <vika...@google.com>
Date: 2017-05-06T02:24:51Z
Remove google api BackOff usage from sdks/core
----
> Thin Java SDK Core
> ------------------
>
> Key: BEAM-1871
> URL: https://issues.apache.org/jira/browse/BEAM-1871
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Daniel Halperin
> Assignee: Luke Cwik
> Fix For: First stable release
>
>
> Before first stable release we need to thin out {{sdk-java-core}} module.
> Some candidates for removal, but not a non-exhaustive list:
> {{sdk/io}}
> * anything BigQuery related
> * anything PubSub related
> * everything Protobuf related
> * TFRecordIO
> * XMLSink
> {{sdk/util}}
> * Everything GCS related
> * Everything Backoff related
> * Everything Google API related: ResponseInterceptors, RetryHttpBackoff, etc.
> * Everything CloudObject-related
> * Pubsub stuff
> {{sdk/coders}}
> * JAXBCoder
> * TableRowJsoNCoder
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
