[
https://issues.apache.org/jira/browse/BEAM-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001737#comment-16001737
]
ASF GitHub Bot commented on BEAM-2076:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2973
[BEAM-2076] Shade Additional Direct Runner Dependencies
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
Add a DirectRunner API Surface Test.
Repackaging runners-core appears to cause the direct runner to hang.
Investigations in progress.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam direct_runner_deps_less_core
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2973.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2973
----
commit 6ce163197d5da03d4750fc89bf617863b385d071
Author: Thomas Groh <tg...@google.com>
Date: 2017-05-03T17:53:12Z
Shade Additional Direct Runner Dependencies
Add a DirectRunner API Surface Test.
Repackaging runners-core appears to cause the direct runner to hang.
Investigations in progress.
----
> DirectRunner: minimal transitive API surface
> --------------------------------------------
>
> Key: BEAM-2076
> URL: https://issues.apache.org/jira/browse/BEAM-2076
> Project: Beam
> Issue Type: Improvement
> Components: runner-direct
> Reporter: Daniel Halperin
> Assignee: Thomas Groh
> Fix For: 2.0.0
>
>
> The {{DirectRunner}} is likely to accidentally be on many users' classpath
> when they are running on other runners. As such, it should have a minimal
> transitive API surface, shading things it needs directly and need not expose.
> My base assumption is that {{runners-core}} should be shaded. There may be
> others tho -- this merits a bit of a look.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
