This is an automated email from the ASF dual-hosted git repository.
yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 8c48120697e Enable error_prone UnnecessaryLongToIntConversion check
(#37783)
8c48120697e is described below
commit 8c48120697eb8145cd984fb8b7839ffeb5a69603
Author: Radosław Stankiewicz <[email protected]>
AuthorDate: Wed Mar 18 02:01:38 2026 +0100
Enable error_prone UnnecessaryLongToIntConversion check (#37783)
---
.../src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy | 1 -
.../streaming/config/StreamingEngineComputationConfigFetcher.java | 2 +-
.../runners/samza/metrics/TestSamzaRunnerWithTransformMetrics.java | 4 ++--
.../beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java | 4 ++--
.../src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOIT.java | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 9e29dd9fc2a..f3edb2bb114 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -1569,7 +1569,6 @@ class BeamModulePlugin implements Plugin<Project> {
"NullableTypeParameter",
"NullableWildcard",
"SuperCallToObjectMethod",
- "UnnecessaryLongToIntConversion",
"UnusedVariable",
// intended suppressions emerged in newer protobuf versions
// For backward compatibility. Public method checked in before
this check impl
diff --git
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java
index 0f50c04d1f0..6ade8440371 100644
---
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java
+++
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java
@@ -181,7 +181,7 @@ public final class StreamingEngineComputationConfigFetcher
implements Computatio
if (config.getMaxWorkItemCommitBytes() != null
&& config.getMaxWorkItemCommitBytes() > 0
&& config.getMaxWorkItemCommitBytes() <= Integer.MAX_VALUE) {
-
operationalLimits.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes().intValue());
+
operationalLimits.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes());
}
if (config.getOperationalLimits() != null) {
diff --git
a/runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaRunnerWithTransformMetrics.java
b/runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaRunnerWithTransformMetrics.java
index dc660ce85af..49143a5b10b 100644
---
a/runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaRunnerWithTransformMetrics.java
+++
b/runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaRunnerWithTransformMetrics.java
@@ -245,7 +245,7 @@ public class TestSamzaRunnerWithTransformMetrics {
// Latency must be positive
assertTrue(latency.getSnapshot().getAverage() > 0);
// Cache size must be 0
- assertEquals(0, cacheSize.getValue().intValue());
+ assertEquals(0L, cacheSize.getValue().longValue());
}
@Test
@@ -318,6 +318,6 @@ public class TestSamzaRunnerWithTransformMetrics {
// Latency must be positive
assertTrue(latency.getSnapshot().getAverage() > 0);
// Cache size must be 0
- assertEquals(0, cacheSize.getValue().intValue());
+ assertEquals(0L, cacheSize.getValue().longValue());
}
}
diff --git
a/runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java
b/runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java
index f94543ef809..75f6ddd5fef 100644
---
a/runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java
+++
b/runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java
@@ -102,7 +102,7 @@ public class TestSamzaTransformMetricsRegistry {
.get("dummy-pvalue.out")
.containsKey(watermarkMessage.getTimestamp()));
// Cache size must be 0
- assertEquals(0, cacheSize.getValue().intValue());
+ assertEquals(0L, cacheSize.getValue().longValue());
}
@Test
@@ -186,6 +186,6 @@ public class TestSamzaTransformMetricsRegistry {
// Check the latency metric is same
assertTrue(1000 == latency.getSnapshot().getAverage());
// Cache size must be 0
- assertEquals(0, cacheSize.getValue().intValue());
+ assertEquals(0L, cacheSize.getValue().longValue());
}
}
diff --git
a/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOIT.java
b/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOIT.java
index d3b8cea7d89..2acacd1a2b6 100644
---
a/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOIT.java
+++
b/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOIT.java
@@ -188,7 +188,7 @@ public class PulsarIOIT {
break;
}
}
- assertEquals(inputsMock.size(), (int) recordsCount);
+ assertEquals(inputsMock.size(), recordsCount);
}
@Test