This is an automated email from the ASF dual-hosted git repository.
yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new b3d2b06b2a8 [ErrorProne] Fix UnnecessaryMethodReference Check Findings
(#37785)
b3d2b06b2a8 is described below
commit b3d2b06b2a802fb64dc536f7a740cc6db4a60dda
Author: Radosław Stankiewicz <[email protected]>
AuthorDate: Fri Mar 20 14:55:44 2026 +0100
[ErrorProne] Fix UnnecessaryMethodReference Check Findings (#37785)
---
.../src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy | 1 -
.../core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java | 6 +++---
.../src/main/java/org/apache/beam/fn/harness/CombineRunners.java | 4 ++--
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index f3edb2bb114..d2c8c324547 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -1557,7 +1557,6 @@ class BeamModulePlugin implements Plugin<Project> {
"TimeUnitConversionChecker",
"UndefinedEquals",
"UnescapedEntity",
- "UnnecessaryMethodReference",
"UnnecessaryParentheses",
"UnrecognisedJavadocTag",
// errorprone 3.2.0+ checks
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java
index 9ef72ee7f27..f58906e464b 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java
@@ -319,21 +319,21 @@ public class TextIOWriteTest {
Iterable<String> aElements =
elements.stream()
- .filter(Predicates.compose(new StartsWith("a"), new
ExtractWriteDestination())::apply)
+ .filter(Predicates.compose(new StartsWith("a"), new
ExtractWriteDestination()))
.collect(Collectors.toList())
.stream()
.map(Functions.toStringFunction())
.collect(Collectors.toList());
Iterable<String> bElements =
elements.stream()
- .filter(Predicates.compose(new StartsWith("b"), new
ExtractWriteDestination())::apply)
+ .filter(Predicates.compose(new StartsWith("b"), new
ExtractWriteDestination()))
.collect(Collectors.toList())
.stream()
.map(Functions.toStringFunction())
.collect(Collectors.toList());
Iterable<String> cElements =
elements.stream()
- .filter(Predicates.compose(new StartsWith("c"), new
ExtractWriteDestination())::apply)
+ .filter(Predicates.compose(new StartsWith("c"), new
ExtractWriteDestination()))
.collect(Collectors.toList())
.stream()
.map(Functions.toStringFunction())
diff --git
a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java
b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java
index 718fe7ee8b6..65e7e85c281 100644
---
a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java
+++
b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java
@@ -123,11 +123,11 @@ public class CombineRunners {
}
void processElement(WindowedValue<KV<KeyT, InputT>> elem) throws Exception
{
- getGroupingTable().put(elem, output::accept);
+ getGroupingTable().put(elem, output);
}
void finishBundle() throws Exception {
- getGroupingTable().flush(output::accept);
+ getGroupingTable().flush(output);
groupingTable = null;
}
}