(beam) branch master updated: [FileWrites] Allow maxNumWritersPerBundle to exceed DEFAULT_MAX_NUM_WRITERS_PER_BUNDLE (20) (#40842)

[yhu]

This is an automated email from the ASF dual-hosted git repository.

Abacn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 4fb2f324649 [FileWrites] Allow maxNumWritersPerBundle to exceed 
DEFAULT_MAX_NUM_WRITERS_PER_BUNDLE (20) (#40842)
4fb2f324649 is described below

commit 4fb2f324649a00482e636bdbb2abf4daa3347ca2
Author: darshan-sj <darshan...@users.noreply.github.com>
AuthorDate: Tue Oct 27 19:05:35 2026 +0000

    [FileWrites] Allow maxNumWritersPerBundle to exceed 
DEFAULT_MAX_NUM_WRITERS_PER_BUNDLE (20) (#40842)
---
 .../core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java     | 8 ++------
 .../core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java | 2 ++
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git 
a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
index 2fd77a1ad0c..ae074629407 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
@@ -345,18 +345,14 @@ public abstract class WriteFiles<UserT, DestinationT, 
OutputT>
    *   </tr>
    * </table>
    *
-   * <p>Note that value provided here cannot exceed the default value ({@link
-   * #DEFAULT_MAX_NUM_WRITERS_PER_BUNDLE}).
+   * <p>The default value is {@link #DEFAULT_MAX_NUM_WRITERS_PER_BUNDLE}.
    */
   public WriteFiles<UserT, DestinationT, OutputT> withMaxNumWritersPerBundle(
       int maxNumWritersPerBundle) {
     checkArgument(
         getMaxNumWritersPerBundle() != -1,
         "Cannot use withMaxNumWritersPerBundle() after withNoSpilling() has 
been set.");
-    checkArgument(
-        maxNumWritersPerBundle > 0 && maxNumWritersPerBundle <= 
DEFAULT_MAX_NUM_WRITERS_PER_BUNDLE,
-        "maxNumWritersPerBundle must be greater than 0 and less than or equal 
to %s",
-        DEFAULT_MAX_NUM_WRITERS_PER_BUNDLE);
+    checkArgument(maxNumWritersPerBundle > 0, "maxNumWritersPerBundle must be 
greater than 0");
     return 
toBuilder().setMaxNumWritersPerBundle(maxNumWritersPerBundle).build();
   }
 
diff --git 
a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java 
b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java
index 09f3f04d5b0..c8d55a8724e 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java
@@ -686,6 +686,8 @@ public class WriteFilesTest {
     assertTrue(write.withEvictWritersWhenFull().getEvictWritersWhenFull());
     assertTrue(write.withEvictWritersWhenFull(true).getEvictWritersWhenFull());
     
assertFalse(write.withEvictWritersWhenFull(false).getEvictWritersWhenFull());
+    assertEquals(50, 
write.withMaxNumWritersPerBundle(50).getMaxNumWritersPerBundle());
+    assertThrows(IllegalArgumentException.class, () -> 
write.withMaxNumWritersPerBundle(0));
   }
 
   @Test