[ https://issues.apache.org/jira/browse/BEAM-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008096#comment-16008096 ]
ASF GitHub Bot commented on BEAM-2280: -------------------------------------- GitHub user peihe opened a pull request: https://github.com/apache/beam/pull/3117 [BEAM-2280] Remove generated archetype folders. Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/peihe/incubator-beam fix-beam-2280 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3117.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3117 ---- commit 9be9eb363b9bc4b152ad9a0930f1d1a3850caa4b Author: Pei He <hepei...@alibaba-inc.com> Date: 2017-05-12T12:59:16Z [BEAM-2280] Remove generated archetype folders. ---- > Examples archetypes build fail when upgrading > --------------------------------------------- > > Key: BEAM-2280 > URL: https://issues.apache.org/jira/browse/BEAM-2280 > Project: Beam > Issue Type: Bug > Components: examples-java > Reporter: Pei He > Assignee: Pei He > Priority: Minor > > WriteWindowedFilesDoFn.java is removed in 2.0.0, but exists in previous > versions. > However, maven-archetypes/examples/generate-sources.sh only rsync existing > files, and won't remove the leftover WriteWindowedFilesDoFn.java. > So, if users have built the module in 0.6.0, after upgrading the built will > fail unless WriteWindowedFilesDoFn.java is removed manually. > LOG > [INFO] [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile > (default-compile) on project basic: Compilation failure: Compilation failure: > [INFO] [ERROR] > /Users/peihe/github/beam/sdks/java/maven-archetypes/examples-java8/target/test-classes/projects/basic/project/basic/src/main/java/it/pkg/common/WriteWindowedFilesDoFn.java:[28,32] > cannot find symbol > [INFO] [ERROR] symbol: class IOChannelFactory > [INFO] [ERROR] location: package org.apache.beam.sdk.util > [INFO] [ERROR] > /Users/peihe/github/beam/sdks/java/maven-archetypes/examples-java8/target/test-classes/projects/basic/project/basic/src/main/java/it/pkg/common/WriteWindowedFilesDoFn.java:[29,32] > cannot find symbol > [INFO] [ERROR] symbol: class IOChannelUtils > [INFO] [ERROR] location: package org.apache.beam.sdk.util > [INFO] [ERROR] -> [Help 1] > [INFO] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to > execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile > (default-compile) on project basic: Compilation failure -- This message was sent by Atlassian JIRA (v6.3.15#6346)