GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/3194
Cleanups in SimpleDoFnRunner and ParDoEvaluator
- Makes it an error to output to an undeclared output tag,
instead of effectively silently dropping this data.
- Removes code in SimpleDoFnRunner that, IIRC, assigned windows to
outputs from bundle methods - which is now obsolete because you
have to specify the window when outputting from FinishBundle,
and you can't output from StartBundle at all.
Also assorted minor cleanups of IntelliJ warnings in affected files.
R: @tgroh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam output-windows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3194
----
commit a1714772bccf2f8810bd56060eba6c29789d324e
Author: Eugene Kirpichov <kirpic...@google.com>
Date: 2017-05-19T23:09:13Z
Cleanups in SimpleDoFnRunner and ParDoEvaluator
- Makes it an error to output to an undeclared output tag,
instead of effectively silently dropping this data.
- Removes code in SimpleDoFnRunner that, IIRC, assigned windows to
outputs from bundle methods - which is now obsolete because you
have to specify the window when outputting from FinishBundle,
and you can't output from StartBundle at all.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
