[
https://issues.apache.org/jira/browse/BEAM-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049928#comment-16049928
]
ASF GitHub Bot commented on BEAM-2440:
--------------------------------------
GitHub user xumingming opened a pull request:
https://github.com/apache/beam/pull/3364
[BEAM-2440] BeamSql: reduce visibility
Since the packages are cross-import each other, many of them can't be set
to `package private` access level.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xumingming/beam BEAM-2440-reduce-visibility
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3364
----
commit 3625dbd9e00db28d2175c6ac000792fd5c5d8f65
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2016-08-09T09:17:32Z
Add DSLs module
commit 7867ce62e43bef7bfd8011c605379df05494dfcf
Author: mingmxu <ming...@ebay.com>
Date: 2017-04-10T02:49:08Z
[BEAM-301] Initial skeleton for Beam SQL
commit f1c2b6540652156ad7c51ec89a933aacb8c6dab6
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2017-04-12T20:00:53Z
[BEAM-301] This closes #2479
commit 529bc9d9375ae162d70de274975c547a878053a3
Author: mingmxu <ming...@ebay.com>
Date: 2017-04-13T21:46:28Z
checkstyle and rename package
correct package from org.beam.dsls.sql to org.apache.beam.dsls.sql
update with checkstyle
commit ca8760373b37b540219301f1e719633956a787dc
Author: Davor Bonaci <da...@google.com>
Date: 2017-04-18T21:40:40Z
This closes #2530
commit aa07a1d41b71c810c4968bd35e5ca69dc56b8c30
Author: Dan Halperin <dhalp...@google.com>
Date: 2017-04-19T19:14:05Z
This closes #2584
commit 464cc275952305bf51ecfdf056e784441c9c2272
Author: mingmxu <ming...@ebay.com>
Date: 2017-04-23T05:20:25Z
redesign BeamSqlExpression to execute Calcite SQL expression.
Changes:
1. revert BEAM dependency to 0.6.0 to avoid impact of changes in master
branch;
2. updates as discussion during review;
refine BeamSqlRowCoder
commit a6845a35fc2a4091dcef24f231c6d3a418561e6f
Author: Davor Bonaci <da...@google.com>
Date: 2017-05-04T07:12:55Z
This closes #2656
commit cf95571d90329287b92946065c93724780f31685
Author: Davor Bonaci <da...@google.com>
Date: 2017-05-04T07:16:34Z
This closes #2878
commit dd70852f6fa811a410938e5baa51cb8e602c931b
Author: James Xu <xumingmi...@gmail.com>
Date: 2017-05-04T03:44:14Z
Fix inconsistent mapping for SQL FLOAT
commit f7ee8d33e13506a17314720c8c23fff486bff76c
Author: Davor Bonaci <da...@google.com>
Date: 2017-05-07T02:24:04Z
This closes #2886
commit a376f37b908828fa0d44b5d71822d51b9c47f971
Author: James Xu <xumingmi...@gmail.com>
Date: 2017-05-04T14:15:02Z
[BEAM-2158] Implement the arithmetic operators
commit 4ea38d82359ed443c906de9caed8488d1dbf199a
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2017-05-09T08:24:20Z
[BEAM-2158] This closes #2893
commit b12c7b49b8eab7b208f2701c412123635813ee28
Author: James Xu <xumingmi...@gmail.com>
Date: 2017-05-05T17:20:54Z
[BEAM-2161] Add support for String operators
commit 3e678a75a746c9e40fdbe6599d20969718c34882
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2017-05-09T12:17:53Z
[BEAM-2161] This closes #2919
commit 59abc7640866f58427817c026af15df30947f3a6
Author: James Xu <xumingmi...@gmail.com>
Date: 2017-05-04T03:44:14Z
[BEAM-2079] Support TextIO as SQL source/sink
commit 7e918a76e409e5c849f2878702746935f4d7bf90
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2017-05-10T05:24:40Z
[BEAM-2079] This closes #2942
commit 3c6d60fb2f473b1860cfeca0f740ec817499d085
Author: mingmxu <ming...@ebay.com>
Date: 2017-05-10T06:04:17Z
[BEAM-2006] window support
Add support for aggregation: global, HOP, TUMBLE, SESSION, only aggregation
function COUNT
fix typo
commit 6729a027daea04d0ad38f8a83ad1baafa465169f
Author: Dan Halperin <dhalp...@google.com>
Date: 2017-05-10T17:03:17Z
This closes #3039
commit f728fbe5c7153341ace046fa8b2465ef8844be1b
Author: mingmxu <ming...@ebay.com>
Date: 2017-05-10T23:38:13Z
Support common-used aggregation functions in SQL, including:
COUNT,SUM,AVG,MAX,MIN
rename BeamAggregationTransform to BeamAggregationTransforms
update comments
commit 523482be0501a7bce79087f47c7752b900178a00
Author: Dan Halperin <dhalp...@google.com>
Date: 2017-05-13T00:47:06Z
This closes #3067
commit 12dd804678bfaad4705c8f1d50eaf03a086f6daf
Author: James Xu <xumingmi...@gmail.com>
Date: 2017-05-10T09:19:48Z
[BEAM-2195] Implement conditional operator (CASE)
commit 8bb59840be32ef945cfb7151ab7f8368fabb19f0
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2017-05-13T06:09:08Z
[BEAM-2195] This closes #3042
commit d74a5c34f0732825c052d4c32096e5b91096a72c
Author: mingmxu <ming...@ebay.com>
Date: 2017-05-13T04:14:29Z
[BEAM-2234] Change return type of buildBeamPipeline to
`PCollection<BeamSQLRow>`
commit 868bcbdad30a2232889d7d439b5190862ae48421
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2017-05-14T05:52:39Z
[BEAM-2234] This closes #3135
commit 8044e59e1bfa175e9d686a4c332be85be22850f1
Author: James Xu <xumingmi...@gmail.com>
Date: 2017-05-12T17:07:01Z
[BEAM-2149] Improved kafka table implemention.
1. use robust CSV library to parse & print.
2. support different data types rather than just `String`.
3. a little cleanup for TextTable (to extract common methods).
commit 0e08c87d7fcc2b8ccd99a422458d12593b60acc2
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2017-05-15T09:23:01Z
[BEAM-2149] This closes #3122
commit 95cba7960552ebfbb594aef1edb775906aec8a79
Author: mingmxu <ming...@ebay.com>
Date: 2017-05-14T04:42:05Z
support UDF
commit 4a7c10746ae8db60600a74570cde0e79d1c98942
Author: mingmxu <ming...@ebay.com>
Date: 2017-05-14T15:56:57Z
update JavaDoc.
commit 36a436ca01cf744fea143a977158faf716a8b65f
Author: Luke Cwik <lc...@google.com>
Date: 2017-05-16T16:06:28Z
[BEAM-2196] support UDF
This closes #3136
----
> DSL SQL: Reduce visibility to simplify backwards compatibility
> --------------------------------------------------------------
>
> Key: BEAM-2440
> URL: https://issues.apache.org/jira/browse/BEAM-2440
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Luke Cwik
> Assignee: James Xu
> Labels: dsl_sql_merge
>
> The package namespace should be flattened into one java package and
> everything made package private except for the public classes like BeamSql,
> BeamSqlCli, BeamSqlRow, BeamSqlRowCoder, ...
> This will simplify the backwards compatibility story after merging since it
> reduces the visible surface that users can interact with.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
