[ https://issues.apache.org/jira/browse/BEAM-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058091#comment-16058091 ]
ASF GitHub Bot commented on BEAM-2392: -------------------------------------- GitHub user nkilmer opened a pull request: https://github.com/apache/beam/pull/3415 [BEAM-2392] Remove uses of proto builder clone Hi @lukecwik, could you please review this? You can merge this pull request into a Git repository by running: $ git pull https://github.com/nkilmer/beam remove-proto-clone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3415.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3415 ---- commit 46a5d0b8c9ca9ecaf7b91d3736d111f331f35a9c Author: Nigel Kilmer <nkil...@google.com> Date: 2017-06-21T18:26:10Z Removed uses of proto builder clone method ---- > Avoid use of proto builder clone > -------------------------------- > > Key: BEAM-2392 > URL: https://issues.apache.org/jira/browse/BEAM-2392 > Project: Beam > Issue Type: Improvement > Components: sdk-java-gcp > Affects Versions: 2.1.0 > Reporter: Nigel Kilmer > Assignee: Nigel Kilmer > Priority: Minor > > BigtableServiceImpl uses the clone method of the MutateRowResponse proto > builder here: > https://github.com/apache/beam/blob/04e3261818aed0c129e7c715e371463bf5b5c1b8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java#L212 > This method is not generated by the Google-internal Java proto generator, so > I had to change this to get it to work with an internal project. Are you > interested in adding this change to the main repository for compatibility, or > would you prefer to keep the cleaner version that uses clone? -- This message was sent by Atlassian JIRA (v6.4.14#64029)