[
https://issues.apache.org/jira/browse/BEAM-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064192#comment-16064192
]
ASF GitHub Bot commented on BEAM-210:
-------------------------------------
GitHub user peihe opened a pull request:
https://github.com/apache/beam/pull/3446
[BEAM-210] WindowingStrategy: add OnTimeBehavior to control whether to emit
empty ON_TIME pane.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peihe/incubator-beam backport-4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3446.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3446
----
commit 311ad8c59439948a0c7f4a2fcece589696b4d09f
Author: Pei He <p...@apache.org>
Date: 2017-06-20T23:09:26Z
WindowingStrategy: add OnTimeBehavior to control whether to emit empty
ON_TIME pane.
commit 26ffd22ee9cb64d54a69f92bfd834796640ee875
Author: Author: 波特 <haozhi....@alibaba-inc.com>
Date: 2017-05-26T09:46:55Z
ReduceFnRunner.onTrigger: add short circuit for empty pane, and move
inputWM and pane after the short circuit.
----
> Allow control of empty ON_TIME panes analogous to final panes
> -------------------------------------------------------------
>
> Key: BEAM-210
> URL: https://issues.apache.org/jira/browse/BEAM-210
> Project: Beam
> Issue Type: Bug
> Components: beam-model-runner-api, sdk-java-core
> Reporter: Mark Shields
> Assignee: Pei He
>
> Today, ON_TIME panes are emitted whether or not they are empty. We had
> decided that for final panes the user would want to control this behavior, to
> control data volume. But for ON_TIME panes no such control exists. The
> rationale is perhaps that the ON_TIME pane is a fundamental result that
> should not be elided. To be considered: whether this is what we want.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
