[
https://issues.apache.org/jira/browse/BEAM-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067389#comment-16067389
]
ASF GitHub Bot commented on BEAM-2537:
--------------------------------------
GitHub user ssisk opened a pull request:
https://github.com/apache/beam/pull/3465
[BEAM-2537] GCP IO ITs now all use --project option
Up until now, some IO ITs used --projectId and others used --project
This mixing meant that running all the tests in one test run was
impossible.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`.
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
Today, the GPC IO ITs use a mix of --project and --projectId pipeline
options. This change fixes it so all the GCP IO ITs use --project
cc @mairbek
R: @jasonkuster @kennknowles
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ssisk/beam io_project_option
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3465.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3465
----
commit 6fe0e4fda2f688b118bf2a8c7d5e41720c9d0214
Author: Stephen Sisk <s...@google.com>
Date: 2017-06-28T22:34:45Z
GCP IO ITs now all use --project option
Up until now, some IO ITs used --projectId and others used --project
This mixing meant that running all the tests in one test run was
impossible.
----
> Can't run IO ITs - conflicting project vs projectId pipeline options
> --------------------------------------------------------------------
>
> Key: BEAM-2537
> URL: https://issues.apache.org/jira/browse/BEAM-2537
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions, sdk-java-gcp
> Reporter: Stephen Sisk
> Assignee: Stephen Sisk
>
> Today, the GPC IO ITs use a mix of --project and --projectId pipeline options.
> eg. GcpOptions.java uses --project:
> https://github.com/apache/beam/blob/master/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L81
> and e.g the datastore IO ITs use that parameter:
> https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/V1ReadIT.java#L60
> however, BigtableTestOptions uses --projectId:
> https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableTestOptions.java#L30
> as does the spanner IO IT:
> https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java#L61
> These conflicts mean that you can't run the tests as a suite successfully if
> you need to manually specify the project.
> This works with the integration tests currently checked in b/c they are using
> the default project values (apache-beam-testing) when running in CI. However,
> that's not an option for running these tests as part of a suite when doing
> local development.
> cc [~jasonkuster]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
