[
https://issues.apache.org/jira/browse/BEAM-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068957#comment-16068957
]
Kenneth Knowles commented on BEAM-2140:
---------------------------------------
Yea, as you say SDF can play by its own rules, so you can certainly just choose
to not drop any timers, and you can clean up stored element+restriction pairs
when your input watermark is far enough along and there are no more timers
pending for that window. Seems likely that in the SDF implementation you might
find an even simpler way to just look at the residual restriction, notice it is
empty, and clear the state.
I don't think an SDF should wait at all in a batch pipeline. In the unified
model, this means bounded-to-bounded SDFs. It doesn't really make sense to even
use timers to implement so I think the discussion is moot.
> Fix SplittableDoFn ValidatesRunner tests in FlinkRunner
> -------------------------------------------------------
>
> Key: BEAM-2140
> URL: https://issues.apache.org/jira/browse/BEAM-2140
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> As discovered as part of BEAM-1763, there is a failing SDF test. We disabled
> the tests to unblock the open PR for BEAM-1763.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
