[ 
https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099249#comment-16099249
 ] 

ASF GitHub Bot commented on BEAM-2676:
--------------------------------------

GitHub user XuMingmin opened a pull request:

    https://github.com/apache/beam/pull/3633

    [BEAM-2676] move BeamSqlRow and BeamSqlRowType to sdk/java/core

    It contains two parts:
    1. remove SQL word in the name,
    `BeamSqlRow` --> `BeamRow`
    `BeamSqlRowType` --> `BeamRowType`
    
    2. move from package `org.apache.beam.dsls.sql.schema` to 
`org.apache.beam.sdk.sd` (**sd** stands for structure data), in module 
`beam-sdks-java-core`
    
    *Hint*: 
    The 4 files are changed to remove dependencies on Calcite/BeamSql, others 
are updated automate by IDE due to class name change:
    * BeamRow.java
    * BeamRowCoder.java
    * BeamRowType.java
    * BeamSqlRowCoderTest.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/XuMingmin/beam BEAM-2676

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3633
    
----
commit 8e9382862cfac475db286b35d5cab379de83615d
Author: mingmxu <ming...@ebay.com>
Date:   2017-07-24T23:03:35Z

    move BeamSqlRow and BeamSqlRowType to sdk/java/core

----


> move BeamSqlRow and BeamSqlRowType to sdk/java/core
> ---------------------------------------------------
>
>                 Key: BEAM-2676
>                 URL: https://issues.apache.org/jira/browse/BEAM-2676
>             Project: Beam
>          Issue Type: Test
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>              Labels: dsl_sql_merge
>
> BeamSqlRow/BeamSqlRowType is the fundamental of structured data processing in 
> Beam, like joins, simple projections/expansions. It's more visible to move 
> them to sdk-java-core.
> It contains two parts:
> 1). remove SQL word in the name,
> BeamSqlRow --> BeamRow
> BeamSqlRowType --> BeamRowType
> 2). move from package {{org.apache.beam.dsls.sql.schema}} to 
> {{org.apache.beam.sdk.sd}} (sd stands for structure data), in module 
> {{beam-sdks-java-core}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to