Add stub DisplayDataTranslation
Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/efe2dc17 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/efe2dc17 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/efe2dc17 Branch: refs/heads/master Commit: efe2dc17af2a66c5c33076467cb46f73bb7fb9ab Parents: 0064fb3 Author: Kenneth Knowles <k...@google.com> Authored: Wed Jul 19 20:09:52 2017 -0700 Committer: Kenneth Knowles <k...@google.com> Committed: Mon Jul 24 18:53:25 2017 -0700 ---------------------------------------------------------------------- .../construction/DisplayDataTranslation.java | 39 ++++++++++++++++++++ .../construction/PTransformTranslation.java | 4 +- 2 files changed, 42 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/efe2dc17/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/DisplayDataTranslation.java ---------------------------------------------------------------------- diff --git a/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/DisplayDataTranslation.java b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/DisplayDataTranslation.java new file mode 100644 index 0000000..ff7f9f2 --- /dev/null +++ b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/DisplayDataTranslation.java @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.beam.runners.core.construction; + +import com.google.protobuf.Any; +import com.google.protobuf.BoolValue; +import org.apache.beam.sdk.common.runner.v1.RunnerApi; +import org.apache.beam.sdk.transforms.display.DisplayData; + +/** Utilities for going to/from DisplayData protos. */ +public class DisplayDataTranslation { + public static RunnerApi.DisplayData toProto(DisplayData displayData) { + // TODO https://issues.apache.org/jira/browse/BEAM-2645 + return RunnerApi.DisplayData.newBuilder() + .addItems( + RunnerApi.DisplayData.Item.newBuilder() + .setId(RunnerApi.DisplayData.Identifier.newBuilder().setKey("stubImplementation")) + .setLabel("Stub implementation") + .setType(RunnerApi.DisplayData.Type.BOOLEAN) + .setValue(Any.pack(BoolValue.newBuilder().setValue(true).build()))) + .build(); + } +} http://git-wip-us.apache.org/repos/asf/beam/blob/efe2dc17/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java ---------------------------------------------------------------------- diff --git a/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java index 3b94724..d459645 100644 --- a/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java +++ b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java @@ -33,6 +33,7 @@ import org.apache.beam.sdk.common.runner.v1.RunnerApi; import org.apache.beam.sdk.common.runner.v1.RunnerApi.FunctionSpec; import org.apache.beam.sdk.runners.AppliedPTransform; import org.apache.beam.sdk.transforms.PTransform; +import org.apache.beam.sdk.transforms.display.DisplayData; import org.apache.beam.sdk.values.PCollection; import org.apache.beam.sdk.values.PInput; import org.apache.beam.sdk.values.POutput; @@ -118,7 +119,8 @@ public class PTransformTranslation { } transformBuilder.setUniqueName(appliedPTransform.getFullName()); - // TODO: Display Data + transformBuilder.setDisplayData( + DisplayDataTranslation.toProto(DisplayData.from(appliedPTransform.getTransform()))); PTransform<?, ?> transform = appliedPTransform.getTransform(); // A RawPTransform directly vends its payload. Because it will generally be
