[
https://issues.apache.org/jira/browse/BEAM-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118736#comment-16118736
]
ASF GitHub Bot commented on BEAM-2724:
--------------------------------------
GitHub user pabloem reopened a pull request:
https://github.com/apache/beam/pull/3684
[BEAM-2724] Preparing support for Structured Names in Dataflow counters
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject
line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
---
* Adding a CounterName class to help support structured names for counters
in the future.
* Also remove function calls from the `apiclient.py` file that are no
longer used.
* And also removing function calls used for aggregators, which have been
dead code for a while.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloem/incubator-beam add-countername
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3684.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3684
----
----
> MSEC counters should support Structured Names in Dataflow
> ---------------------------------------------------------
>
> Key: BEAM-2724
> URL: https://issues.apache.org/jira/browse/BEAM-2724
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
