[ 
https://issues.apache.org/jira/browse/BEAM-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121906#comment-16121906
 ] 

Xu Mingmin commented on BEAM-2747:
----------------------------------

You're right [~xumingming], it's doable to copy `AggregationFunctionImpl` given 
that `public AggImplementor getImplementor(boolean windowContext)` is not 
actually used in Beam SQL(That method has lots of dependencies but we only use 
the parser of Calcite).

> accept CombineFn as UDAF
> ------------------------
>
>                 Key: BEAM-2747
>                 URL: https://issues.apache.org/jira/browse/BEAM-2747
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>              Labels: dsl_sql_merge, dsl_sql_review
>
> refer to 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=AAAABTmjhgo



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to