[
https://issues.apache.org/jira/browse/BEAM-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159457#comment-16159457
]
ASF GitHub Bot commented on BEAM-407:
-------------------------------------
GitHub user justintumale opened a pull request:
https://github.com/apache/beam/pull/3827
BEAM-407: fixes inconsistent synchronization in OffsetRangeTracker.copy
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Added synchronized getters and setters for the class attributes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justintumale/beam master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3827.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3827
----
commit 64f1db399c1cf424b5bd385bc5543908c095619a
Author: Justin Tumale <[email protected]>
Date: 2017-09-08T22:14:06Z
BEAM-407: Removed OffsetRangeTracker bugs
commit 464ea9626c1b97a29d6f0432c06ed4b6dc41e94f
Author: Justin Tumale <[email protected]>
Date: 2017-09-08T22:20:36Z
BEAM-407: fixes inconsistent synchronization in OffsetRangeTracker.copy
----
> Inconsistent synchronization in OffsetRangeTracker.copy
> -------------------------------------------------------
>
> Key: BEAM-407
> URL: https://issues.apache.org/jira/browse/BEAM-407
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Justin Tumale
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs
> IS2_INCONSISTENT_SYNC|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L148]:
> Inconsistent synchronization
> Applies to:
> [OffsetRangeTracker.copy|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/OffsetRangeTracker.java#L263].
> Its mutating methods are all marked synchronized otherwise.
> This is a good starter bug. When fixing, please remove the corresponding
> entries from
> [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
> and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
