[ 
https://issues.apache.org/jira/browse/BEAM-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183085#comment-16183085
 ] 

ASF GitHub Bot commented on BEAM-2959:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3904


> Fix proto enums to not use 0 for a valid value
> ----------------------------------------------
>
>                 Key: BEAM-2959
>                 URL: https://issues.apache.org/jira/browse/BEAM-2959
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>
> Proto3 uses 0 as the default value for enums and does not encode it on the 
> wire which means that you can not detect the difference between a value that 
> is unset and an enum that is set but has a value of zero.
> Defining an "YYY_UNSPECIFIED" is considered a best practice. Unfortunately 
> this is not done automatically because of proto2 compatibility within proto3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to