[
https://issues.apache.org/jira/browse/BEAM-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183491#comment-16183491
]
ASF GitHub Bot commented on BEAM-2958:
--------------------------------------
GitHub user youngoli opened a pull request:
https://github.com/apache/beam/pull/3915
[BEAM-2958] Adding a top-level user agent string to PipelineOptions
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject
line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Adding a string to PipelineOptions that can be used for setting a user
agent string with information about the distribution of Beam being used. That
string can be sent to external services too.
This PR is probably not completely done yet. While the actual user agent
string is in and working, more might have to be done to replace BigTableIO and
DataflowRunner usages of user agents to use this new one. I'm still working on
that right now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/youngoli/beam bugfix-2958
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3915.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3915
----
commit a70ff0bd973807cc99b1aee65c372476a295259b
Author: Daniel Oliveira <daniel.o.program...@gmail.com>
Date: 2017-09-27T19:24:17Z
[BEAM-2958] Adding user agent string to PipelineOptions.
commit e56ebf6b034f0b0d0f98e35ea2a18b852593d373
Author: Daniel Oliveira <daniel.o.program...@gmail.com>
Date: 2017-09-28T00:14:02Z
[BEAM-2958] Adding a unit test for UserAgentFactory.
----
> Expose a top level user agent PipelineOption which can be communicated to
> external services
> -------------------------------------------------------------------------------------------
>
> Key: BEAM-2958
> URL: https://issues.apache.org/jira/browse/BEAM-2958
> Project: Beam
> Issue Type: Improvement
> Components: runner-apex, runner-dataflow, runner-direct,
> runner-flink, runner-gearpump, runner-jstorm, runner-mapreduce, runner-spark,
> runner-tez, sdk-java-core, sdk-java-gcp
> Reporter: Luke Cwik
> Assignee: Daniel Oliveira
> Priority: Minor
>
> This concept is used by Bigtable and Dataflow service to specify what version
> of the SDK is being used and is currently available through ReleaseInfo as a
> static property.
> The Dataflow distribution attempts to override this but is unable to
> propagate this user agent to dependent modules cleanly. Having dependent
> modules get the user agent from a PipelineOption would make it possible for a
> runner to modify the user agent during execution to be able to identify its
> flavor.
> It seems likely that Flink/Spark/... would like to modify the user agent as
> well for the same purpose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
