[ 
https://issues.apache.org/jira/browse/BEAM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215810#comment-16215810
 ] 

ASF GitHub Bot commented on BEAM-3092:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/4027

    [BEAM-3092] Fix RAT plugin configuration

    Follow this checklist to help us incorporate your contribution quickly and 
easily:
    
     - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
     - [x] Each commit in the pull request should have a meaningful subject 
line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
     - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam RAT

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4027.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4027
    
----
commit 57c1e57d5e7d78e5b0ca3b1d434ea4b528da036a
Author: Kenneth Knowles <k...@apache.org>
Date:   2017-10-23T19:36:38Z

    Rearrange .gitignore slightly

commit dfb6a6c75ff2fca342bf0695cdd547c03f04148c
Author: Kenneth Knowles <k...@apache.org>
Date:   2017-10-23T20:26:08Z

    Make pom.xml match .gitignore

commit 3e045eeef67a2218559743904099c2e329203481
Author: Kenneth Knowles <k...@apache.org>
Date:   2017-10-23T20:26:27Z

    Manage RAT plugin more centrally; only toggle skipping

----


> RAT configuration is sensitive to $PWD
> --------------------------------------
>
>                 Key: BEAM-3092
>                 URL: https://issues.apache.org/jira/browse/BEAM-3092
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Blocker
>
> This is currently breaking the build, as our Jenkins config does the 
> equivalent of {{mvn -f src/pom.xml}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to