Suppress AutoValue warnings in TextIO

Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/26a3fc55
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/26a3fc55
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/26a3fc55

Branch: refs/heads/master
Commit: 26a3fc55596139f96084ff6310defb0609791d6d
Parents: 50de293
Author: Kenneth Knowles <[email protected]>
Authored: Thu Oct 26 12:43:08 2017 -0700
Committer: Kenneth Knowles <[email protected]>
Committed: Thu Oct 26 20:14:54 2017 -0700

----------------------------------------------------------------------
 .../java/org/apache/beam/sdk/io/TextIO.java     | 24 ++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/26a3fc55/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java
index 6e6bb2f..fb01634 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java
@@ -269,11 +269,19 @@ public class TextIO {
   /** Implementation of {@link #read}. */
   @AutoValue
   public abstract static class Read extends PTransform<PBegin, 
PCollection<String>> {
-    @Nullable abstract ValueProvider<String> getFilepattern();
+    @Nullable
+    abstract ValueProvider<String> getFilepattern();
+
     abstract MatchConfiguration getMatchConfiguration();
+
     abstract boolean getHintMatchesManyFiles();
+
     abstract Compression getCompression();
-    @Nullable abstract byte[] getDelimiter();
+
+    @SuppressWarnings("mutable") // this returns an array that can be mutated 
by the caller
+    @Nullable
+    abstract byte[] getDelimiter();
+
     abstract Builder toBuilder();
 
     @AutoValue.Builder
@@ -430,8 +438,12 @@ public class TextIO {
   public abstract static class ReadAll
       extends PTransform<PCollection<String>, PCollection<String>> {
     abstract MatchConfiguration getMatchConfiguration();
+
     abstract Compression getCompression();
-    @Nullable abstract byte[] getDelimiter();
+
+    @SuppressWarnings("mutable") // this returns an array that can be mutated 
by the caller
+    @Nullable
+    abstract byte[] getDelimiter();
 
     abstract Builder toBuilder();
 
@@ -512,7 +524,11 @@ public class TextIO {
   public abstract static class ReadFiles
       extends PTransform<PCollection<FileIO.ReadableFile>, 
PCollection<String>> {
     abstract long getDesiredBundleSizeBytes();
-    @Nullable abstract byte[] getDelimiter();
+
+    @SuppressWarnings("mutable") // this returns an array that can be mutated 
by the caller
+    @Nullable
+    abstract byte[] getDelimiter();
+
     abstract Builder toBuilder();
 
     @AutoValue.Builder

Reply via email to