[BEAM-2482] - CodedValueMutationDetector should use the coders structural value
Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/84da6cac Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/84da6cac Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/84da6cac Branch: refs/heads/mr-runner Commit: 84da6caca58a52731f9cf5d9b6bfb85977241925 Parents: e3f6d6f Author: Luke Cwik <lc...@google.com> Authored: Wed Nov 1 10:43:11 2017 -0700 Committer: Luke Cwik <lc...@google.com> Committed: Wed Nov 1 10:43:11 2017 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/beam/sdk/util/MutationDetectors.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/84da6cac/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java index 3556667..79b960a 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java @@ -108,8 +108,8 @@ public class MutationDetectors { public CodedValueMutationDetector(T value, Coder<T> coder) throws CoderException { this.coder = coder; // We need to clone the original value before getting it's structural value. - // If the object is consistent with equals, the Structural value will be the exact - // same object reference making it impossible to detect changes. + // If the object is consistent with equals, the Structural value will be the + // exact same object reference making it impossible to detect changes. clonedOriginalValue = CoderUtils.clone(coder, value); this.originalStructuralValue = coder.structuralValue(clonedOriginalValue); this.possiblyModifiedObject = value;
