[
https://issues.apache.org/jira/browse/BEAM-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272202#comment-16272202
]
ASF GitHub Bot commented on BEAM-3243:
--------------------------------------
rmannibucau commented on a change in pull request #4185: BEAM-3243 better error
message when there are conflicting anonymous names
URL: https://github.com/apache/beam/pull/4185#discussion_r153991859
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
##########
@@ -636,4 +649,49 @@ public void visitPrimitiveTransform(Node node) {
node.getTransform().validate(options);
}
}
+
+ private static class TransformToMessage implements Function<PTransform<?,
?>, String> {
+ @Override
+ public String apply(final PTransform<?, ?> transform) {
+ final Object representant;
+ if (ParDo.SingleOutput.class.isInstance(transform)) {
+ representant = ParDo.SingleOutput.class.cast(
+ transform).getFn();
+ } else if (ParDo.MultiOutput.class.isInstance(transform)) {
+ representant = ParDo.MultiOutput.class.cast(
+ transform).getFn();
+ } else {
+ representant = transform;
+ }
+ return " - " + representant;
+ }
+ }
+
+ private static class UnstableNameToMessage implements Function<String,
String> {
+ private final Multimap<String, PTransform<?, ?>> instances;
+
+ private UnstableNameToMessage(final Multimap<String, PTransform<?, ?>>
instancePerName) {
+ this.instances = instancePerName;
+ }
+
+ @Override
+ public String apply(final String input) {
+ Collection<PTransform<?, ?>> values = null;
+ String currentName = input;
+ // strip the counter appended to the name,
+ // see uniquifyInternal().
+ // common example: ParDo(Anonymous) becoming ParDo(Anonymous)2
+ while (values == null && !currentName.isEmpty()) {
+ currentName = currentName.substring(0, currentName.length() - 1);
Review comment:
The loop will remove both digits normally.
Thought about removing it but then you need to browse the whole collection
instead of just testing if the list is empty - twice. No strong opinion on it
but thought that holding the direct information "conflict" was valuable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> multiple anonymous DoFn lead to conflicting names
> -------------------------------------------------
>
> Key: BEAM-3243
> URL: https://issues.apache.org/jira/browse/BEAM-3243
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Romain Manni-Bucau
> Fix For: 2.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
