[jira] [Commented] (BEAM-2795) FlinkRunner: translate using SDK-agnostic means

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/BEAM-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300602#comment-16300602
 ] 

ASF GitHub Bot commented on BEAM-2795:
--------------------------------------

lukecwik closed pull request #4291: [BEAM-2795] Key FlinkRunner batch 
translation by URN
URL: https://github.com/apache/beam/pull/4291
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java
 
b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java
index 3689698c1c6..a4265f59bf7 100644
--- 
a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java
+++ 
b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java
@@ -28,6 +28,8 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
+import javax.annotation.Nullable;
+import org.apache.beam.runners.core.construction.PTransformTranslation;
 import org.apache.beam.runners.flink.translation.functions.FlinkAssignWindows;
 import org.apache.beam.runners.flink.translation.functions.FlinkDoFnFunction;
 import 
org.apache.beam.runners.flink.translation.functions.FlinkMergingNonShuffleReduceFunction;
@@ -96,29 +98,34 @@
 
   @SuppressWarnings("rawtypes")
   private static final Map<
-      Class<? extends PTransform>,
+      String,
       FlinkBatchPipelineTranslator.BatchTransformTranslator> TRANSLATORS = new 
HashMap<>();
 
   static {
-    TRANSLATORS.put(View.CreatePCollectionView.class, new 
CreatePCollectionViewTranslatorBatch());
+    TRANSLATORS.put(PTransformTranslation.CREATE_VIEW_TRANSFORM_URN,
+        new CreatePCollectionViewTranslatorBatch());
 
-    TRANSLATORS.put(Combine.PerKey.class, new CombinePerKeyTranslatorBatch());
-    TRANSLATORS.put(GroupByKey.class, new GroupByKeyTranslatorBatch());
-    TRANSLATORS.put(Reshuffle.class, new ReshuffleTranslatorBatch());
+    TRANSLATORS.put(PTransformTranslation.COMBINE_TRANSFORM_URN,
+        new CombinePerKeyTranslatorBatch());
+    TRANSLATORS.put(PTransformTranslation.GROUP_BY_KEY_TRANSFORM_URN,
+        new GroupByKeyTranslatorBatch());
+    TRANSLATORS.put(PTransformTranslation.RESHUFFLE_URN, new 
ReshuffleTranslatorBatch());
 
-    TRANSLATORS.put(Flatten.PCollections.class, new 
FlattenPCollectionTranslatorBatch());
+    TRANSLATORS.put(PTransformTranslation.FLATTEN_TRANSFORM_URN,
+        new FlattenPCollectionTranslatorBatch());
 
-    TRANSLATORS.put(Window.Assign.class, new WindowAssignTranslatorBatch());
+    TRANSLATORS.put(PTransformTranslation.WINDOW_TRANSFORM_URN, new 
WindowAssignTranslatorBatch());
 
-    TRANSLATORS.put(ParDo.MultiOutput.class, new ParDoTranslatorBatch());
+    TRANSLATORS.put(PTransformTranslation.PAR_DO_TRANSFORM_URN, new 
ParDoTranslatorBatch());
 
-    TRANSLATORS.put(Read.Bounded.class, new ReadSourceTranslatorBatch());
+    TRANSLATORS.put(PTransformTranslation.READ_TRANSFORM_URN, new 
ReadSourceTranslatorBatch());
   }
 
 
   static FlinkBatchPipelineTranslator.BatchTransformTranslator<?> 
getTranslator(
       PTransform<?, ?> transform) {
-    return TRANSLATORS.get(transform.getClass());
+    @Nullable String urn = 
PTransformTranslation.urnForTransformOrNull(transform);
+    return urn == null ? null : TRANSLATORS.get(urn);
   }
 
   private static class ReadSourceTranslatorBatch<T>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FlinkRunner: translate using SDK-agnostic means
> -----------------------------------------------
>
>                 Key: BEAM-2795
>                 URL: https://issues.apache.org/jira/browse/BEAM-2795
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-flink
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>              Labels: portability
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)