[ https://issues.apache.org/jira/browse/BEAM-3749?focusedWorklogId=79314&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-79314 ]
ASF GitHub Bot logged work on BEAM-3749: ---------------------------------------- Author: ASF GitHub Bot Created on: 11/Mar/18 21:48 Start Date: 11/Mar/18 21:48 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #4826: [BEAM-3749] Add test for a trigger with windowed SQL query URL: https://github.com/apache/beam/pull/4826#issuecomment-372152468 @XuMingmin what do you think? Including these tests will make sure the current functionality is never lost. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 79314) Time Spent: 3h 10m (was: 3h) > support customized trigger/accumulationMode in BeamSql > ------------------------------------------------------ > > Key: BEAM-3749 > URL: https://issues.apache.org/jira/browse/BEAM-3749 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Xu Mingmin > Assignee: Xu Mingmin > Priority: Major > Fix For: 2.5.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Currently BeamSql use {{DefaultTrigger}} for aggregation operations. > By adding two options {{withTrigger(Trigger)}} and > {{withAccumulationMode(AccumulationMode)}}, developers can specify their own > aggregation strategies with BeamSql. > [~xumingming] [~kedin] [~kenn] for any comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)