[
https://issues.apache.org/jira/browse/BEAM-3841?focusedWorklogId=79668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-79668
]
ASF GitHub Bot logged work on BEAM-3841:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/18 00:07
Start Date: 13/Mar/18 00:07
Worklog Time Spent: 10m
Work Description: markflyhigh commented on issue #4856: [BEAM-3841] Fix
TestDataflowRunner.run to run_pipeline
URL: https://github.com/apache/beam/pull/4856#issuecomment-372502819
+R: @robertwb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 79668)
Time Spent: 20m (was: 10m)
> Python TestDataflowRunner should oeverride run_pipeline
> -------------------------------------------------------
>
> Key: BEAM-3841
> URL: https://issues.apache.org/jira/browse/BEAM-3841
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [TestDataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py]
> is inherited from
> [DataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py].
> Basically, it wraps DataflowRunner.run_pipeline and provide more test
> actions.
> However DataflowRunner.run renamed to run_pipeline in [this
> commit|https://github.com/apache/beam/commit/8cf222d3db1188aff5432af548961fc670f97635],
> but run function in TestDataflowRunner didn't change.
> We should change it accordingly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
