[ 
https://issues.apache.org/jira/browse/BEAM-2281?focusedWorklogId=80414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80414
 ]

ASF GitHub Bot logged work on BEAM-2281:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/18 17:18
            Start Date: 14/Mar/18 17:18
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on issue #4865: [BEAM-2281][Sql] Use 
SqlFunctions.toBigDecimal not toString
URL: https://github.com/apache/beam/pull/4865#issuecomment-373104099
 
 
   Tests were failing because precision information was being lost in the 
string conversion, so some tests were asserting the wrong values. Tests should 
pass now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 80414)
    Time Spent: 1h 10m  (was: 1h)

> call SqlFunctions in operator implementation
> --------------------------------------------
>
>                 Key: BEAM-2281
>                 URL: https://issues.apache.org/jira/browse/BEAM-2281
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Calcite has a collections of functions in 
> {{org.apache.calcite.runtime.SqlFunctions}}. It sounds a good source to 
> leverage when adding operators as {{BeamSqlExpression}}. 
> [~xumingming] [~app-tarush], any comments?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to