[
https://issues.apache.org/jira/browse/BEAM-2898?focusedWorklogId=80940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80940
]
ASF GitHub Bot logged work on BEAM-2898:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/18 19:01
Start Date: 15/Mar/18 19:01
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #4783:
[BEAM-2898] Support Impulse transforms in Flink batch runner
URL: https://github.com/apache/beam/pull/4783#discussion_r173033901
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/GreedyPipelineFuser.java
##########
@@ -72,10 +72,10 @@ private GreedyPipelineFuser(Pipeline p) {
/**
* Fuses a {@link Pipeline} into a collection of {@link ExecutableStage}s.
*
- * <p>This fuser expects each PTransform to have exactly one input. This
means that pipelines must
- * use Impulse/ParDo transformations rather than read nodes. The utilities in
- * {@link org.apache.beam.runners.core.construction.JavaReadViaImpulse} can
be used to translate
- * non-compliant pipelines.
+ * <p>This fuser expects each PTransform which has no inputs to have an
associated environment.
+ * This means that pipelines must use Impulse/ParDo transformations rather
than read nodes. The
Review comment:
"This means that pipelines must be rooted at Impulse, or other
runner-executed primitive transforms, instead of primitive Read nodes."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 80940)
Time Spent: 2h 40m (was: 2.5h)
> Flink supports chaining/fusion of single-SDK stages
> ---------------------------------------------------
>
> Key: BEAM-2898
> URL: https://issues.apache.org/jira/browse/BEAM-2898
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Henning Rohde
> Priority: Major
> Labels: portability
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The Fn API supports fused stages, which avoids unnecessarily round-tripping
> the data over the Fn API between stages. The Flink runner should use that
> capability for better performance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
