[
https://issues.apache.org/jira/browse/BEAM-3819?focusedWorklogId=80985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80985
]
ASF GitHub Bot logged work on BEAM-3819:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/18 21:29
Start Date: 15/Mar/18 21:29
Worklog Time Spent: 10m
Work Description: pawel-kaczmarczyk commented on issue #4851: [BEAM-3819]
Add withLimit() option to KinesisIO
URL: https://github.com/apache/beam/pull/4851#issuecomment-373528960
I like the idea and the code looks good. I would only consider changing the
property name as `limit` is not much informative. Maybe `requestRecordsLimit`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 80985)
Time Spent: 40m (was: 0.5h)
> Add withLimit() option to KinesisIO
> -----------------------------------
>
> Key: BEAM-3819
> URL: https://issues.apache.org/jira/browse/BEAM-3819
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kinesis
> Reporter: Jean-Baptiste Onofré
> Assignee: Alexey Romanenko
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In some cases, the user might need to set the {{limit}} on the
> {{SimplifiedKinesisClient}}, especially for performance reason, depending of
> the number of records.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
