[ https://issues.apache.org/jira/browse/BEAM-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401182#comment-16401182 ]
Mark Liu commented on BEAM-3841: -------------------------------- Fix PR [4856|https://github.com/apache/beam/pull/4856] is merged. > Python TestDataflowRunner should oeverride run_pipeline > ------------------------------------------------------- > > Key: BEAM-3841 > URL: https://issues.apache.org/jira/browse/BEAM-3841 > Project: Beam > Issue Type: Bug > Components: testing > Reporter: Mark Liu > Assignee: Mark Liu > Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > [TestDataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py] > is inherited from > [DataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py]. > Basically, it wraps DataflowRunner.run_pipeline and provide more test > actions. > However DataflowRunner.run renamed to run_pipeline in [this > commit|https://github.com/apache/beam/commit/8cf222d3db1188aff5432af548961fc670f97635], > but run function in TestDataflowRunner didn't change. > We should change it accordingly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)