[ 
https://issues.apache.org/jira/browse/BEAM-3060?focusedWorklogId=81014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81014
 ]

ASF GitHub Bot logged work on BEAM-3060:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Mar/18 23:21
            Start Date: 15/Mar/18 23:21
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on a change in pull request 
#4870: [BEAM-3060] Fixing mvn dependency issue when runnning filebasedIOIT t…
URL: https://github.com/apache/beam/pull/4870#discussion_r174959913
 
 

 ##########
 File path: sdks/java/io/file-based-io-tests/pom.xml
 ##########
 @@ -294,6 +294,12 @@
                     <version>${apache.hadoop.version}</version>
                     <scope>runtime</scope>
                 </dependency>
+                <dependency>
+                    <groupId>javax.xml.bind</groupId>
+                    <artifactId>jaxb-api</artifactId>
 
 Review comment:
   Thanks. Can you also define JAXB dependencies in 
https://github.com/apache/beam/blob/master/sdks/java/io/xml/pom.xml in root 
level and update that component to use the version defined in the root level. 
Also, can't we use 2.2.3 instead of 2.2.2 which seems to be pretty old ? I 
think we could run into issues if we have to use both 2.2.0 and 2.2.3 for 
different components.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 81014)
    Time Spent: 3h 10m  (was: 3h)

> Add performance tests for commonly used file-based I/O PTransforms
> ------------------------------------------------------------------
>
>                 Key: BEAM-3060
>                 URL: https://issues.apache.org/jira/browse/BEAM-3060
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-core
>            Reporter: Chamikara Jayalath
>            Assignee: Szymon Nieradka
>            Priority: Major
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> We recently added a performance testing framework [1] that can be used to do 
> following.
> (1) Execute Beam tests using PerfkitBenchmarker
> (2) Manage Kubernetes-based deployments of data stores.
> (3) Easily publish benchmark results. 
> I think it will be useful to add performance tests for commonly used 
> file-based I/O PTransforms using this framework. I suggest looking into 
> following formats initially.
> (1) AvroIO
> (2) TextIO
> (3) Compressed text using TextIO
> (4) TFRecordIO
> It should be possibly to run these tests for various Beam runners (Direct, 
> Dataflow, Flink, Spark, etc.) and file-systems (GCS, local, HDFS, etc.) 
> easily.
> In the initial version, tests can be made manually triggerable for PRs 
> through Jenkins. Later, we could make some of these tests run periodically 
> and publish benchmark results (to BigQuery) through PerfkitBenchmarker.
> [1] https://beam.apache.org/documentation/io/testing/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to