[
https://issues.apache.org/jira/browse/BEAM-3418?focusedWorklogId=81028&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81028
]
ASF GitHub Bot logged work on BEAM-3418:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/18 00:15
Start Date: 16/Mar/18 00:15
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #4587:
[BEAM-3418] Send worker_id in all grpc channels to runner harness
URL: https://github.com/apache/beam/pull/4587#discussion_r174969164
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -176,6 +176,13 @@ def __init__(self, packages, options,
environment_version, pipeline_url):
if self.debug_options.experiments:
for experiment in self.debug_options.experiments:
self.proto.experiments.append(experiment)
+ # Add MULTIPLE_SDK_CONTAINERS flag if its not already present. Do not add
+ # the flag if 'NO_MULTIPLE_SDK_CONTAINERS' is present.
+ # TODO: Cleanup MULTIPLE_SDK_CONTAINERS once we depricate Python SDK till
+ # version 2.4.
+ if ('MULTIPLE_SDK_CONTAINERS' not in self.proto.experiments and
Review comment:
I expect this CL to get in 2.5.
In a way this flag is required to help router distinguish between old SDK
(sdk till 2.4) and new SDK (sdk from 2.5). So once we do not have any sdk which
is older than 2.5, we don't need to distinguish between sdk atleast for
MultiSdk functionality and hence it automatically becomes the default feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 81028)
Time Spent: 40m (was: 0.5h)
> Python Fnapi - Support Multiple SDK workers on a single VM
> ----------------------------------------------------------
>
> Key: BEAM-3418
> URL: https://issues.apache.org/jira/browse/BEAM-3418
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Labels: performance, portability
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Support multiple python SDK process on a VM to fully utilize a machine.
> Each SDK Process will work in isolation and interact with Runner Harness
> independently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
